Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3-dot-menu of file not closable when navigating via keyboard #10790

Closed
jancborchardt opened this issue Aug 21, 2018 · 8 comments · Fixed by #39808
Closed

3-dot-menu of file not closable when navigating via keyboard #10790

jancborchardt opened this issue Aug 21, 2018 · 8 comments · Fixed by #39808
Labels
1. to develop Accepted and waiting to be taken care of 26-feedback bug design Design, UI, UX, etc. feature: accessibility

Comments

@jancborchardt
Copy link
Member

When you Tab through the elements via keyboard and open the 3-dot-menu of a file using Enter, you can not close it again by pressing Enter another time. This is possible using the mouse and should also be possible with the keyboard.

cc @nextcloud/javascript @skjnldsv @juliushaertl what is missing here?

@jancborchardt jancborchardt added bug 1. to develop Accepted and waiting to be taken care of high feature: accessibility labels Aug 21, 2018
@jancborchardt jancborchardt added this to the Nextcloud 14 milestone Aug 21, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #10788 ("More apps" menu not operable via keyboard), #1450 (If 3-dot menu only has one action, show that action directly), #3522 (Three dots menu in files in greyed out), #7159 (Breadcrumbs ··· menu not closable, New menu outside visible area), and #10008 (Unable to open file or folder with keyboard).

@MorrisJobke
Copy link
Member

Something for 15 and maybe a backport to stable14 later.

@jancborchardt jancborchardt added the design Design, UI, UX, etc. label Dec 21, 2018
@MorrisJobke MorrisJobke modified the milestones: Nextcloud 16, Nextcloud 17 Apr 5, 2019
@skjnldsv
Copy link
Member

Closed in the components.
Will slowly be gone as we move to the component everywhere (already in quite a lot of places :) )

@jancborchardt
Copy link
Member Author

@skjnldsv this is specifically about the Files app – which I guess won’t be using components in 17 or for some time?

@skjnldsv
Copy link
Member

Title was generic, I assumed you meant as a global way.
Well, this interlace with the various vue migration issues we have opened.
I'd say it's not really needed to keep this opened as I'm not sure anyone will work on it until it's easier to know what we're doing in the files code (aka migrating to vue ;) )

But if you still want it opened, you can :)

@jancborchardt
Copy link
Member Author

Since it’s an accessbility issue open since 14, I would prefer to keep it open until it is actually fixed in a release. ;) Just so we don’t forget.

@rullzer rullzer modified the milestones: Nextcloud 17.0.4, Nextcloud 17.0.5 Mar 11, 2020
@rullzer rullzer modified the milestones: Nextcloud 17.0.5, Nextcloud 17.0.6 Mar 23, 2020
@skjnldsv skjnldsv removed this from the Nextcloud 17.0.6 milestone Apr 10, 2020
@szaimen
Copy link
Contributor

szaimen commented Jan 9, 2023

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 9, 2023
@juliusknorr
Copy link
Member

Still valid

@juliusknorr juliusknorr added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jan 9, 2023
@skjnldsv skjnldsv moved this to Done in Files to vue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 26-feedback bug design Design, UI, UX, etc. feature: accessibility
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants