Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move/copy picker: Possible to accidentally choose same folder, receive error #11313

Closed
jancborchardt opened this issue Sep 21, 2018 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.

Comments

@jancborchardt
Copy link
Member

Currently when moving/copying a file via the file picker, you can accidentally choose the same folder you are just moving as a target. In that case you just get an error "Could not move folder".

Instead, the current folder that you are moving should be grayed out to make clear that it’s the current folder being moved.

What do you think @nextcloud/designers

@jancborchardt jancborchardt added bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 1. to develop Accepted and waiting to be taken care of feature: files feature: filepicker papercut Annoying recurring issue with possibly simple fix. and removed feature: filepicker labels Sep 21, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #2851 (Moving shared folders), #4149 (Moveing file/folder selection), #3369 (Sharing of folders are not possible), #7629 (Create Folders when moving files), and #5448 (Error moving / renaming folders NC 12.0.0 (stable)).

@pixelipo
Copy link
Contributor

Since we have both "Move" and "Copy" buttons, your approach makes most sense. Otherwise, Move action would default to Copy in case destination folder == source folder

@MorrisJobke
Copy link
Member

Should maybe combined with #9931 (copy to same folder should create a duplicate file) and remove/gray out the "Move" button as @pixelipo explained it.

@szaimen
Copy link
Contributor

szaimen commented May 20, 2021

At least copying into the same folder works now as far as I can see on c.nc.c. (it creates a new file which is named the same + (copy))
Please reopen or create a new issue if you still want to implement this for moving.

@szaimen szaimen closed this as completed May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

No branches or pull requests

7 participants