Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertisement "Get your own free account" placed below shared filed page #11788

Closed
geonom opened this issue Oct 12, 2018 · 7 comments
Closed
Labels

Comments

@geonom
Copy link

geonom commented Oct 12, 2018

Steps to reproduce

  1. Share a file via link
  2. Click on the link
  3. On the bottom of the page a link to nextcloud signup appears

Expected behaviour

No external advertising without my consent. Even if this flag in the config file were working, which it somehow isn't:

'simpleSignUpLink.shown' => true,

Actual behaviour

There is external advertisement added without my consent, potentially confusing users into thinking it was message from me, as it is linked directly to my cloud store name tag, see:
https://cloud.geoadel.net/index.php/s/3aiPpzcGd9A8R9F

Server configuration

Nextcloud

Version: 14.0.1.1

Installed Apps: 35

Apps updates availlable: 0
PHP Version: 7.0.30

RAM-Limit: 512 MB

Maximum Execution time limit: 3600

Max Size for Uploads: 511 MB

Database: mysql

Version: 5.7.21

Updated from an older Nextcloud/ownCloud or fresh install:
Updated from nextcloud

Where did you install Nextcloud from:
all-inkl.com is the provider

Signing status:

Signing status No errors have been found.

Nextcloud configuration:

Config report ``` array ( 0 => 'cloud.geoadel.net', ), 'overwrite.cli.url' => 'http://cloud.geoadel.net', 'dbtype' => 'mysql', 'version' => '14.0.1.1', 'dbhost' => 'localhost', 'dbport' => '', 'mysql.utf8mb4' => true, 'installed' => true, 'maintenance' => false, 'theme' => '', 'loglevel' => 2, 'simpleSignUpLink.shown' => true, );
</details>


**Are you using encryption:** I don't think so



@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #11198 ("Get your own free account"), #11327 (Can I delete ""Get your own free account""Share URL?), #7238 (Share still exists after source file gets deleted), #4020 (Search on public share pages), and #11644 (Getting 503 Error While Trying to Access the Shared File).

@kesselb
Copy link
Contributor

kesselb commented Oct 12, 2018

May I ask you why you open a new Issue when you found the one with the solution already?

#11198
#11327
#11101

/**
* By default there is on public pages a link shown that allows users to
* learn about the "simple sign up" - see https://nextcloud.com/signup/
*
* If this is set to "false" it will not show the link.
*/
'simpleSignUpLink.shown' => true,

@geonom
Copy link
Author

geonom commented Oct 12, 2018

Sure, as I wrote above, the fix does not work on my nextcloud installation. I hope that is not simply my incompetence at implementing the fix in the config file (which is a possibility, though I tried to check as best I can :) ).

For that reason I included my config file (minus the password and salt stuff)...

@geonom
Copy link
Author

geonom commented Oct 12, 2018

Ah, forget it, stupid me indeed, thanks!

@geonom geonom closed this as completed Oct 12, 2018
@geonom
Copy link
Author

geonom commented Oct 12, 2018

I thought the fix would be to simply copy "the fix", then instead you have to change the flag from true to false, to actually have the fix... that is slightly confusing though of course if you read and understand the comment above, it becomes quite clear, my fault.

To me, that flag not being false by default actually is an issue, but well... at least the "fix" is working :)

@root1599
Copy link

/core/templates/layout.public.php is where you will find the file containing it

@Sx3

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants