Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve expired share message #12062

Closed
MorrisJobke opened this issue Oct 26, 2018 · 6 comments · Fixed by #16723
Closed

Improve expired share message #12062

MorrisJobke opened this issue Oct 26, 2018 · 6 comments · Fixed by #16723
Assignees
@skjnldsv
Labels
3. to review Waiting for reviews enhancement feature: activity and notification feature: sharing papercut Annoying recurring issue with possibly simple fix.
Milestone
Nextcloud 18.0.0

Comments

@MorrisJobke
Copy link
Member

  • having a share with an expiry date
  • once this is reached an activity is created (and maybe send to the user via email)
  • expected: it says "share has expired"
  • actual: "{actor} removed you from {file}" which is confusing to users and does not reflect the automatic expiry of the share

cc @nickvergessen
@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Oct 26, 2018
@nextcloud-bot

This comment has been minimized.

Sign in to view
@rullzer
Copy link
Member

rullzer commented Nov 5, 2018

So this happens because we have internal expiration dates now. And they are basically removed the moment a user (either sharer or recipient) check the share in some way.

@nickvergessen Do you think it is enough to check the expiration date and conclude on the basis of that if it is an expiration or not?

@nickvergessen
Copy link
Member

So user shares can expire now?

Well i guess we simply remove/ignore the user in this case

@rullzer
Copy link
Member

rullzer commented Nov 8, 2018

Yeah was added in 14 by @schiessle

@MorrisJobke MorrisJobke mentioned this issue Nov 22, 2018
Closed
@MorrisJobke
Copy link
Member Author

@nickvergessen Mind to look into this?

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label May 22, 2019
@skjnldsv skjnldsv self-assigned this Aug 7, 2019
@skjnldsv skjnldsv added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Aug 12, 2019
@skjnldsv skjnldsv mentioned this issue Aug 12, 2019
Merged
@skjnldsv
Copy link
Member

See #16723 & nextcloud/activity#383

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement feature: activity and notification feature: sharing papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging a pull request may close this issue.

Add expiration event for shares nextcloud/server
5 participants
@rullzer @nickvergessen @MorrisJobke @skjnldsv @nextcloud-bot