Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide notification-indicator when no notifications are available #12221

Closed
newhinton opened this issue Nov 2, 2018 · 2 comments
Closed

Hide notification-indicator when no notifications are available #12221

newhinton opened this issue Nov 2, 2018 · 2 comments

Comments

@newhinton
Copy link
Contributor

I would suggest to hide the empty notification-element, if there are no things to display. If there is nothing in there, this element serves no purpose and could be hidden.

Or is there a specific reason why the notification-indicator is always shown? If i remember correctly, it was hidden pre Nextcloud 14.

@nextcloud/designers

@MorrisJobke
Copy link
Member

Or is there a specific reason why the notification-indicator is always shown? If i remember correctly, it was hidden pre Nextcloud 14.

We actually added it as "always there" to indicate that this is a UI element and to make it accessible. Also GitHub does it for example like that. I couldn't find the original issue anymore, but we said, that we should show it always and not only in case there is something new.

@jancborchardt
Copy link
Member

Find the whole discussion at nextcloud/notifications#2 ;)

(I’ll close this as it’s definitely something for the Notifications app.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants