New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI job to check for fixup commits #12414

Closed

rullzer opened this issue Nov 12, 2018 · 4 comments

Labels

enhancement technical debt

Member

rullzer commented Nov 12, 2018

Just to make sure we do not merge those.

CC: @ChristophWurst @MorrisJobke

rullzer added enhancement technical debt labels

Member

ChristophWurst commented Nov 12, 2018

Member

ChristophWurst commented Nov 12, 2018

Ref https://dev.to/tmr232/dont-amend-fix for those curious about git commit --fixup

nextcloud deleted a comment from nextcloud-bot

Member

MorrisJobke commented Nov 16, 2018

It's done now by GitHub checks.

MorrisJobke closed this as completed

Member

MorrisJobke commented Nov 16, 2018

https://github.com/nextcloud/server/pull/12484/checks?check_run_id=32464067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment