audit.log: password protecting or setting/changing the expiration date of a "share link" should generate an event in audit.log

[bgraabek]

Steps to reproduce

1. Enable a "share link" on a file or folder
2. password protect the share link
   or
3. change the expiration date

Expected behaviour

The audit.log file should log whether a share link has an expiration date and whether it is password protected.
Also, if the expiration date is changed or the password is changed at a later time this should also be logged.

Actual behaviour

An event is only written to the audit.log file when a share link is enabled and when it is disabled.

Server configuration

Operating system:
Ubuntu 16.04.5
Web server:

Database:

PHP version:

Nextcloud version: (see Nextcloud admin page)
14.03
Updated from an older Nextcloud/ownCloud or fresh install:
Update

[nextcloud-bot]

GitMate.io thinks possibly related issues are #8785 (Password expiration), #12232 (Share link menu disappears when setting expiration date), #4525 (Expiration date of shared links is not set even when it's forced), #4078 (sharing by mail doesn't allow password, expiration date, secure drop), and #11710 (Setting start dates for shares (similar to expiration dates)).

[PVince81]

tested with Nextcloud 22.2.0 and admin_audit 1.12.0 and I could see these events logged in the audit log:

{"reqId":"8FHaAeKzlc9Qi1mrnnPn","level":1,"time":"2021-11-11T16:51:22+00:00","remoteAddr":"127.0.0.1","user":"admin","app":"admin_audit","method":"PUT","url":"/ocs/v2.php/apps/files_sharing/api/v1/shares/5","message":"The expiration date of the publicly shared file with ID \"3\" has been changed to \"2021-11-13 00:00:00\"","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36","version":"22.2.0.2"}
{"reqId":"7RwlyAEsN3X6U4It6ybX","level":1,"time":"2021-11-11T16:51:40+00:00","remoteAddr":"127.0.0.1","user":"admin","app":"admin_audit","method":"PUT","url":"/ocs/v2.php/apps/files_sharing/api/v1/shares/5","message":"The password of the publicly shared file \"7S2H5KCmKtNFys3\" with ID \"3\" has been changed","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36","version":"22.2.0.2"}
{"reqId":"uy01taGzmkdvMWaA7Vxr","level":1,"time":"2021-11-11T16:51:53+00:00","remoteAddr":"127.0.0.1","user":"admin","app":"admin_audit","method":"PUT","url":"/ocs/v2.php/apps/files_sharing/api/v1/shares/5","message":"The password of the publicly shared file \"7S2H5KCmKtNFys3\" with ID \"3\" has been changed","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36","version":"22.2.0.2"}
{"reqId":"35D33ILdZGhRHsrbTxcj","level":1,"time":"2021-11-11T16:51:57+00:00","remoteAddr":"127.0.0.1","user":"admin","app":"admin_audit","method":"PUT","url":"/ocs/v2.php/apps/files_sharing/api/v1/shares/5","message":"The expiration date of the publicly shared file with ID \"3\" has been removed","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36","version":"22.2.0.2"}

so probably this was implemented recently, closing