visual feedback if a note attached to a share was send successfully to the recipient

[schiessle]

Right now it is a bit hard to see if a share note was send out correctly. The drop down always looks like this:

How about replacing the arrow with a "sent" confirmation label and only turn it back to an arrow if the user modifies the note? This way you not only get immediately a feedback if the note was sent out correctly but you also see that it was already successfully sent out if you come back to the drop-down a few days later.

cc @nextcloud/designers

[nextcloud-bot]

GitMate.io thinks possibly related issues are #11270 ("Note to recipient" API), #11352 (Send note to recipient: previously content not visible on shared link), #5658 (share by email - password email not sent - solved), #9055 (share-internal / calendar-task-note file attached ), and #3830 (No calendar invitation send for event in shared calendars ).

[violoncelloCH]

didn't you mean "sent" instead of "send"? just to be gramatically correct... otherwise 👍

[schiessle]

@violoncelloCH true 😉

[jancborchardt]

Instead of the text, we could simply show the icon-checkmark:

https://docs.nextcloud.com/server/15/developer_manual/design/icons.html

It will always have the same size (also as the confirm icon) and not break depending on language.

[szaimen]

@nextcloud/javascript do you have some pointers? I would then go ahead and create a PR to fix this issue.

[juliushaertl]

server/apps/files_sharing/src/components/SharingEntryLink.vue

Lines 271 to 285 in c8e0809

	<ActionTextEditable v-if="hasNote"
	ref="note"
	v-tooltip.auto="{
	content: errors.note,
	show: errors.note,
	trigger: 'manual',
	defaultContainer: '#app-sidebar'
	}"
	:class="{ error: errors.note}"
	:disabled="saving"
	:placeholder="t('files_sharing', 'Enter a note for the share recipient')"
	:value="share.newNote || share.note"
	icon="icon-edit"
	@update:value="onNoteChange"
	@submit="onNoteSubmit" />

would be where the input is built but it might require to extend the shared component to give some proper feedback there https://nextcloud-vue-components.netlify.app/#/Components/Actions?id=actiontexteditable

[szaimen]

hm... that's maybe a bit to complicated for me. I though it would already be enough to subsitute the arrow through the checkmark...
But thanks for the pointer!