Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow functions cause issues on IE #12875

Closed
2 tasks
ChristophWurst opened this issue Dec 6, 2018 · 1 comment
Closed
2 tasks

Arrow functions cause issues on IE #12875

ChristophWurst opened this issue Dec 6, 2018 · 1 comment
Labels
1. to develop Accepted and waiting to be taken care of bug regression

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 6, 2018

Similar to fixes like #12340 and #12860, we have to make sure our scripts and script bundles don't use the arrow function syntax as it's not supported on IE.

Steps to reproduce

  1. Use arrow function in a script
  2. Transpile with babel
  3. Still get a syntax error

Expected behaviour

Scripts should work on all supported browsers, including IE. Apps (and server) should use the transformation plugin for Babel like nextcloud-libraries/nextcloud-password-confirmation#2.

Actual behaviour

Sytax errors and therefore broken scripts.

Server configuration

Nextcloud version:

Starting somewhere around Nextcloud 14


... not a complete list yet, needs investigation

cc @nextcloud/javascript

@ChristophWurst ChristophWurst added bug 1. to develop Accepted and waiting to be taken care of regression labels Dec 6, 2018
@juliusknorr
Copy link
Member

Seems fixed to me with 15dc9d8 for updatenotifications and settings has a proper babelrc file as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug regression
Projects
None yet
Development

No branches or pull requests

2 participants