Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show deleted files / trash size #14138

Closed
wookietreiber opened this issue Feb 11, 2019 · 16 comments
Closed

show deleted files / trash size #14138

wookietreiber opened this issue Feb 11, 2019 · 16 comments
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: trashbin javascript
Milestone

Comments

@wookietreiber
Copy link

Is your feature request related to a problem? Please describe.
The deleted files (view=trashbin) neither shows the size of the trash (the entire trash) nor the sizes of the files / directories contained in the trash. This makes it hard to decide when and what to remove if you don't simply want to empty the entire trash.

Describe the solution you'd like
Show the sizes like in the normal file view.

Describe alternatives you've considered
None.

Additional context

Trash shows no file sizes:

screenshot-firefox-2019-02-11-09-19-34

Normal folder view shows file sizes:

screenshot-firefox-2019-02-11-09-22-08

@wookietreiber wookietreiber added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Feb 11, 2019
@alexanderdd
Copy link
Contributor

Also, you should be able to sort by file size, as in the normal folder view (so you can start deleting the largest files).
Thanks to whoever is working on this.

@stale
Copy link

stale bot commented Jun 5, 2019

This issue has been automatically marked as stale because it has not had recent activity and it seems to be missing some essential informations. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Ticket or PR with no recent activity label Jun 5, 2019
@alexanderdd
Copy link
Contributor

15.0.7 -- I would still like to see this enhancement, especially including sort by size. I need this feature a lot so I can free up disk space starting with the biggest files first.
(comment to remove stale label)

@stale stale bot removed the stale Ticket or PR with no recent activity label Jun 5, 2019
@alexanderdd
Copy link
Contributor

It seems to me it should be fairly easy to implement the same file view for trash as in regular folder view, including file size and ability to sort by size, and deletion date.

Or should I open a separate issue for "sorting files by size in trash view"?

@alexanderdd
Copy link
Contributor

I can confirm that this is still not implemented in 19.0.4 =(

@alexanderdd
Copy link
Contributor

Can you triage this please? @juliushaertl @skjnldsv

@juliusknorr
Copy link
Member

Makes sense to have I'd say (cc @nextcloud/designers)

@nimishavijay
Copy link
Member

Yep, all of that makes sense. The size in the trash bin can be exactly where it is for the normal files and it can allow sorting by size too.

@juliusknorr juliusknorr added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 10, 2021
@rakekniven
Copy link
Member

rakekniven commented Jul 1, 2022

Allow sorting the trash bin by size would be really helpful.

Note: Not available at v24.0.2

@alexanderdd
Copy link
Contributor

alexanderdd commented Aug 2, 2022

@rakekniven

Note: Note available at v24.0.2

did you mean "now available"? so this bug is closed?

@rakekniven
Copy link
Member

rakekniven commented Aug 3, 2022

did you mean "now available"? so this bug is closed?

Sorry for my spelling issue, just adapted my comment. "Not available" is the right wording and therefor issue is still open.

@being-peace
Copy link

Related to #24544.

@J0WI
Copy link
Contributor

J0WI commented Apr 11, 2023

The API call under /remote.php/dav/trashbin/<user>/trash already returns the file size but it's not shown in the list.

@szaimen
Copy link
Contributor

szaimen commented Apr 11, 2023

Cc @skjnldsv the size is now shoen after the rewrite, right?

@skjnldsv
Copy link
Member

Yep, done already! 🚀

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Apr 11, 2023
@skjnldsv skjnldsv self-assigned this Apr 11, 2023
@skjnldsv skjnldsv added this to the Nextcloud 27 milestone Apr 11, 2023
@skjnldsv
Copy link
Member

Allow sorting the trash bin by size would be really helpful.

Sorting also implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: trashbin javascript
Projects
Status: Done
Development

No branches or pull requests

9 participants