Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating file header jumps to top on sorting #15438

Closed
tobiasKaminsky opened this issue May 8, 2019 · 9 comments · Fixed by #39808
Closed

Floating file header jumps to top on sorting #15438

tobiasKaminsky opened this issue May 8, 2019 · 9 comments · Fixed by #39808
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 26-feedback bug feature: files

Comments

@tobiasKaminsky
Copy link
Member

  • scroll down a bit
  • click on a table header e.g. Date for sorting
  • see that file list jumps to top

instead it position should remain, but only content should change.

@tobiasKaminsky tobiasKaminsky added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels May 8, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 17 milestone May 9, 2019
@rullzer rullzer modified the milestones: Nextcloud 17.0.4, Nextcloud 17.0.5 Mar 11, 2020
@rullzer rullzer modified the milestones: Nextcloud 17.0.5, Nextcloud 17.0.6 Mar 23, 2020
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of feature: files and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 21, 2020
@szaimen

This comment was marked as off-topic.

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 9, 2023
@tobiasKaminsky

This comment was marked as resolved.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Mar 1, 2023
@skjnldsv skjnldsv self-assigned this Mar 1, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Mar 2, 2023

What should be the expected behaviour btw, if you sort everything, keeping the scrolling position would most likely not show the relevancy the user is looking for?

@tobiasKaminsky
Copy link
Member Author

instead it position should remain, but only content should change.

This is what I am used to on other file listings, e.g. Dolphin on Linux, or Thunderbird.

@skjnldsv
Copy link
Member

skjnldsv commented Mar 2, 2023

Good from me 🤷‍♂️
@jancborchardt @nimishavijay, you good with that?

@nimishavijay
Copy link
Member

🤔 what @skjnldsv said about scrolling to show relevant info makes sense to me as well, on checking other apps it truly is a mixed bag. Windows file explorer and Google Drive scroll on changing sort order, while Dropbox, Nautilus on Ubuntu and the other apps @tobiasKaminsky mentioned don't scroll. I would go with scrolling for same reason @skjnldsv mentioned, ccing @jancborchardt here

@jancborchardt
Copy link
Member

We do a hard refresh on re-sorting, so pretty difficult to keep the position anyway?

I would also agree with @skjnldsv and @nimishavijay’s research in that it makes a bit more sense to scroll to top since the whole content changed.

A quick animation that scrolls to the top of the list would of course be nice, but yeah with the hard refresh it’s difficult.

@skjnldsv
Copy link
Member

skjnldsv commented Mar 2, 2023

We do a hard refresh on re-sorting, so pretty difficult to keep the position anyway?

There is some options possible. It's easy to remember the top-to-scroll-position pixel amount, but depending on what we wanna achieve, some stuff can and can't be done :)

What about this:

  1. If a file is focused, we scroll to its position on a sorting change
  2. If a file is selected (or a group) we scroll to the first selected item
  3. If there is is none, we scroll up top

@skjnldsv
Copy link
Member

skjnldsv commented Mar 2, 2023

A quick animation that scrolls to the top of the list would of course be nice, but yeah with the hard refresh it’s difficult.

Also, keep in mind files to vue is still ongoing, a hard refresh might be avoidable here (just re-rendering might be possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 26-feedback bug feature: files
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants