Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading group individual unshare activities #15759

Closed
ChristophWurst opened this issue May 27, 2019 · 3 comments · Fixed by nextcloud/activity#379
Closed

Misleading group individual unshare activities #15759

ChristophWurst opened this issue May 27, 2019 · 3 comments · Fixed by nextcloud/activity#379
Assignees
@nickvergessen
Labels
3. to review Waiting for reviews bug feature: activity and notification feature: files

Comments

@ChristophWurst
Copy link
Member

Steps to reproduce

  1. Create two new users and add them to a new group
  2. Share a folder with the group
  3. Remove the received share as one of the new users

Expected behaviour

  • Admin gets notification <user> removed themselves from the share named <name>
  • Other user gets <user> removed themselves from the share named <name>

Actual behaviour

  • Admin gets <user> removed you from the share named <name> (unshared_group_self)
  • Other user gets <user> removed you from the share named <name> (unshared_by)

Server configuration

Nextcloud version: 15 & 16
@ChristophWurst ChristophWurst added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: files feature: activity and notification labels May 27, 2019
@ChristophWurst
Copy link
Member Author

cc @nextcloud/sharing

@ChristophWurst
Copy link
Member Author

cc @nextcloud/sharing

🏓 any opinion? Can you confirm this is bugged?

@nickvergessen nickvergessen self-assigned this Jun 21, 2019
@nickvergessen nickvergessen mentioned this issue Jun 21, 2019
Merged
@nickvergessen
Copy link
Member

Fix is at nextcloud/activity#379

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug feature: activity and notification feature: files
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "unshare group share from self" activity nextcloud/activity
2 participants
@nickvergessen @ChristophWurst