Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual indication of Comments in Webui #17376

Closed
sunjam opened this issue Oct 2, 2019 · 5 comments
Closed

Visual indication of Comments in Webui #17376

sunjam opened this issue Oct 2, 2019 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: comments

Comments

@sunjam
Copy link

sunjam commented Oct 2, 2019

Hi, I'd like to encourage adding a visual indication of comments to the webui of the Files app. This could make it easier to browse and access comments. Currently, comment status is only displayed in the Activity and Recommendations app. In the Files app, it is buried under ... menu > Details > Comments

Suggestion:

show-comments-webui

This tells me there are comments about this folder.

2-new-comments

And, this tells me there are two new and unread comments!

I like either of these examples because they are visually clear, can be used to access comments easily, and match up with the current functionality of viewing a Favorite Star or seeing what is actively shared at a glance.
Screen Shot 2019-10-02 at 11 40 59 AM

Edit: Discussion about comments started here.

@sunjam sunjam added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Oct 2, 2019
@Spartachetto
Copy link

I signal two related issues.

One is #6424 (Indicator for tagged files in list) which starts with: "It looks like there is no hint or any sign, when a file has tags or comments". So maybe the two issues are similar...

The other one is nextcloud/android#2908, which is about displaying comments in the android client.

I seem to remember also a discussion with the participation of @jancborchardt in which different possible icons for the presence of comments were discussed, with the possibility to distinguish between the presence of a comment by the same user, an unread comment from another user and a read comment from another user. I am sorry but I do not recall which issue was.

I do think that knowing which file has comments without opening the details would be very useful

@jancborchardt
Copy link
Member

We need to think about mobile first, and also about the grid view. An additional icon in the list is not going to work there.

So I’d say we could have an indicator which is combined with the 3-dot action icon, like either a comment-icon overlapped.

Then when you open the action menu, the "Details" entry could have a subline saying "3 new comments".

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. feature: comments and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Oct 25, 2019
@Spartachetto
Copy link

I am fine with not having this kind of information on mobile and in grid view.

Yet I'd really like to see all the files with comments (and tags) in a folder without the need to open all the details entries when I am not in the grid view!

This same behaviour would be the same of most file managers of the different operating systems I know:

  • in grid view you see something of the content of the file (image preview, beginning of the text, ...)
  • in detailed view you see more details of the data about the file. Here comments and tags status of the file would fit perfectly, in my humble opinion...

@thomasgg23
Copy link

Would love to see this enhancement with the icons for the comments.

For the mobile view, couldn't there be an icon including the comment symbol like the star symbol for the favorite files?

@marcelklehr
Copy link
Member

This has landed some time ago, now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: comments
Projects
None yet
Development

No branches or pull requests

5 participants