-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to scss #1786
Comments
If that is possible: 👍 Otherwise that would be kinda of a bummer to tell people to do "just these 10 steps to change CSS files" ;) |
Yup, as talked about if we have an on-the-fly SCSS compiler it’s good. :) If not it’s a very annoying barrier. |
Yep! This is mandatory! |
well, this can be integrated with the task runners we use for the applications at-least. So, no additional steps for the app standpoint. |
@raghunayyar you mean cron? How will we handle the compiling if the user load nextcloud but the cron hasn't started? |
@raghunayyar having a task runner for core development is exactly what we want to avoid ;) it’s about on-the fly CSS generation. |
@skjnldsv I meant something like grunt / gulp / webpack. But @jancborchardt seems legit about avoiding that hastle in core. It can be taken in account for apps though. |
No way. We will not introduce such stuff - it only confused people - new ones in the same way as existing contributors. |
Really nice that you guys switch. I agree 200% with @raghunayyar we should have a task runner to. @MorrisJobke I don't think you can confuse people if you only to run one command to run the taskrunner. Grunt serve, or Gulp serve its very easy and remove complexity. It bring not only the sass compiler but the server, the minify tools (for image and code) and all other stuff you have to manually. But since this are PHP based maybe compass are more "nice". |
No we won't implement this. This has been discussed sooo many times before, and we want to avoid that. Having a direct compilation and a cache system is the easiest way. |
As you guys want, its a step forward anyway. Just thinking in what is more easy. I just think its more easy to new guys have the project if you have taskrunner that install all the depencies. But it can be only me. |
I know what it is. This are introduced in nextcloud website, but removed after some time. I don't think this are a good practice have a script that compiles the code. It will load all the page with only html and after some time it compile the code. If you are in a slow network this will hurt a lot. So if this script is only for develpment I think its okay, if are for production I don't think so... |
As far as I can tell, my server isn't having any trouble. And it's a one-time compilation. Lambda user won't have any issue. |
@Espina2 afaik its compiled using PHP, not the JavaScript compiler |
@BernhardPosselt @skjnldsv |
Well, on a non-dev user installation, the scss won't change except maybe after an update. So only a single compilation will ensue. |
So what you are saying is when this are released you only have the css compiled in the folder, and further "tweaks" should be done in that css file? |
I suppose the first web request will compile it |
@skjnldsv I think this one is done :) We could refine based on the current state step by step if needed. Thanks for this awesome contribution :) |
This is becoming more and more needed. The more we wait, the harder it will gets for us to make the switch later.
Sooooooo let's do this!
Why
Goals
Numbers
Roadmap
fixes.cssfonts.cssglobal.cssjquery.ocdialog.cssmobile.cssupdate.cssOptionnal
@Henni @MorrisJobke @BernhardPosselt @jancborchardt
The text was updated successfully, but these errors were encountered: