Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial share expiration date not written to DB #19786

Closed
wiswedel opened this issue Mar 5, 2020 · 3 comments
Closed

Initial share expiration date not written to DB #19786

wiswedel opened this issue Mar 5, 2020 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: file sidebar Related to the file sidebar component feature: sharing needs info

Comments

@wiswedel
Copy link
Contributor

wiswedel commented Mar 5, 2020

Steps to reproduce

  1. make sure Settings > Sharing > Set default expiration date for shares is not activated
  2. browse to a file or folder
  3. create a share (this report applies for email shares, public shares, user shares and group shares)
  4. open the share's ... menu
  5. click Set expiration date

Expected behaviour

  • The first possible expiration date is auto-entered into the date field below
  • That date is written into the database

Actual behaviour

  • Today's date (which is besides an invalid value) is auto-entered into the date field
  • Nothing is written into oc_share.expiration

tested with NC 18.0.1, 18.0.0 and 16.0.5

@wiswedel wiswedel added bug feature: sharing 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: file sidebar Related to the file sidebar component labels Mar 5, 2020
@wiswedel wiswedel changed the title Initial expiration date not written to DB Initial share expiration date not written to DB Mar 5, 2020
@wiswedel
Copy link
Contributor Author

Issue still exists with Nextcloud 19 and 20.

Thinking of it, this is even a security risk: The sharing user is in good faith that their share will auto-expire. However the share remains exposed until the end of all time.

@PVince81 PVince81 added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Mar 18, 2021
@PVince81
Copy link
Member

still happening on master.
indeed, even closing the dropdown doesn't save anything and reopening shows today's date

@szaimen
Copy link
Contributor

szaimen commented Nov 26, 2022

Hi, please update to at least 23.0.12 and report back if it fixes the issue. Thank you!

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Nov 26, 2022
@szaimen szaimen removed the security label Jan 14, 2023
@szaimen szaimen closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: file sidebar Related to the file sidebar component feature: sharing needs info
Projects
None yet
Development

No branches or pull requests

3 participants