Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favorite handling fails for folders not in the filelist #19789

Closed
nickvergessen opened this issue Mar 5, 2020 · 4 comments · Fixed by #39808
Closed

Favorite handling fails for folders not in the filelist #19789

nickvergessen opened this issue Mar 5, 2020 · 4 comments · Fixed by #39808
Labels
1. to develop Accepted and waiting to be taken care of 26-feedback bug feature: file sidebar Related to the file sidebar component

Comments

@nickvergessen
Copy link
Member

Steps to reproduce

  1. Create a folder
  2. Navigate into the folder
  3. Open the sidebar via the share icon in the breadcrumb
  4. Click on the favorite icon

Expected behaviour

Works ⭐

Actual behaviour

Works in the background, but the UI shows an error: Unable to change the favourite state of the file

The problem is OCA.Files.App.fileList.getModelForFile can not find the file and therefor continues with null, causing the following error in the console:

Unable to change favourite state TypeError: "fileInfoModel is null"

cc @skjnldsv
@nickvergessen nickvergessen added bug 1. to develop Accepted and waiting to be taken care of feature: file sidebar Related to the file sidebar component labels Mar 5, 2020
@nickvergessen nickvergessen added this to the Nextcloud 19 milestone Mar 5, 2020
@skjnldsv
Copy link
Member

skjnldsv commented Mar 5, 2020

Stupid legacy code :p

@nickvergessen
Copy link
Member Author

It could also be fixed by reducing the scope of the catch to the actual axios execution

@rullzer rullzer removed this from the Nextcloud 19 milestone May 7, 2020
@szaimen
Copy link
Contributor

szaimen commented Jan 9, 2023

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 9, 2023
@nickvergessen
Copy link
Member Author

Also on master

@nickvergessen nickvergessen added 1. to develop Accepted and waiting to be taken care of 26-feedback and removed needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 10, 2023
@skjnldsv skjnldsv mentioned this issue Aug 16, 2023
Merged
@skjnldsv skjnldsv moved this to Done in Files to vue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of 26-feedback bug feature: file sidebar Related to the file sidebar component
Projects
Files to vue
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(f2v): migrate Files nextcloud/server
4 participants
@rullzer @nickvergessen @skjnldsv @szaimen