Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAV and OCS requests should not initiate a web session #19805

Closed
ChristophWurst opened this issue Mar 6, 2020 · 2 comments
Closed

DAV and OCS requests should not initiate a web session #19805

ChristophWurst opened this issue Mar 6, 2020 · 2 comments
Labels
1. to develop Accepted and waiting to be taken care of bug feature: authentication

Comments

@ChristophWurst
Copy link
Member

For historical reasons we use sessions for clients (desktop, mobile). While we block logins with app passwords right now, it is still possible to circumvent this check with an authenticated request to a DAV route as it starts a session as well.

App passwords always have access to the full account, so no data is leaked.

Steps to reproduce

  1. Open Nextcloud in the browser
  2. Open a valid DAV URL
  3. Fill in the basic auth dialog with an app password
  4. Go back to the document root

Expected behaviour

Not logged in

Actual behaviour

Logged in

Server configuration

Nextcloud version:

Any

@ChristophWurst ChristophWurst added bug 1. to develop Accepted and waiting to be taken care of feature: authentication labels Mar 6, 2020
@ChristophWurst
Copy link
Member Author

cc @juliushaertl @rullzer

@ChristophWurst
Copy link
Member Author

Shockingly accurate duplicate of #7628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug feature: authentication
Projects
None yet
Development

No branches or pull requests

1 participant