-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if apps still use View
(rather than Node
)
#1987
Comments
Maybe we should also add this as a policy for apps published over our appstore 🤔 @BernhardPosselt |
@MariusBluem nope, definitely not a goal there. The last thing that we want is to run a PHP parser over abitrary code. |
No, also the Node API is not always suitable atm. |
Isn't this already integrated into core btw :D? Maybe the way to go is to just modify the default .travis.yml like this https://github.com/nextcloud/news/blob/master/.travis.yml#L48 |
I suppose this issue is still valid? If not, please close this issue! |
Yeah it's still heavily used as the node api doesn't allow to do all/the same things the view can |
View
(rather than Node
)
See discussion in #1233
Apps should not use private classes. We should start warning in the code checker and maybe even the logs. Apps should use the Node API. And if stuff is missing from there we should invest time in adding that functionality.
The node API was introduced ~3 years ago. So I'd say apps should migrate ASAP!
CC: @icewind1991 @nickvergessen
The text was updated successfully, but these errors were encountered: