Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if apps still use View (rather than Node) #1987

Open
rullzer opened this issue Nov 2, 2016 · 6 comments
Open

Warn if apps still use View (rather than Node) #1987

rullzer opened this issue Nov 2, 2016 · 6 comments
Labels

Comments

@rullzer
Copy link
Member

rullzer commented Nov 2, 2016

See discussion in #1233

Apps should not use private classes. We should start warning in the code checker and maybe even the logs. Apps should use the Node API. And if stuff is missing from there we should invest time in adding that functionality.

The node API was introduced ~3 years ago. So I'd say apps should migrate ASAP!

CC: @icewind1991 @nickvergessen

@MariusBluem
Copy link
Member

Maybe we should also add this as a policy for apps published over our appstore 🤔 @BernhardPosselt

@BernhardPosselt
Copy link
Member

@MariusBluem nope, definitely not a goal there. The last thing that we want is to run a PHP parser over abitrary code.

@nickvergessen
Copy link
Member

No, also the Node API is not always suitable atm.

@BernhardPosselt
Copy link
Member

Isn't this already integrated into core btw :D?

Maybe the way to go is to just modify the default .travis.yml like this https://github.com/nextcloud/news/blob/master/.travis.yml#L48

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@skjnldsv skjnldsv removed stale Ticket or PR with no recent activity labels Jun 12, 2019
@szaimen
Copy link
Contributor

szaimen commented May 21, 2021

I suppose this issue is still valid? If not, please close this issue!

@nickvergessen
Copy link
Member

Yeah it's still heavily used as the node api doesn't allow to do all/the same things the view can

@joshtrichards joshtrichards changed the title Warn if apps use the view Warn if apps still use View (rather than Node) Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants