Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Open in ONLYOFFICE" to "View..." or "Edit in ONLYOFFICE" according to the share permissions #20785

Closed
loelkes opened this issue May 2, 2020 · 2 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement integration needs info stale Ticket or PR with no recent activity

Comments

@loelkes
Copy link

loelkes commented May 2, 2020

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
After sharing a document via a public link it is not clearly visible for the receiving user that this document is shared as read-only. Even after opening ONLYOFFICE there's no message that the document is read-only. Users who are not familiar with the different UIs of ONLYOFFICE (almost no buttons in read-only mode) might think that something is malfunctioning.

Describe the solution you'd like
Instead of "Open in ONLYOFFICE" change the buttons according to the share state to "View in ONLYOFFICE (read-only)" and "Edit in ONLYOFFICE".

Describe alternatives you've considered
Feature request to ONLYOFFICE so that the editor shows a warning.

Additional context
A user shared a document and forgot or mistakenly did not enable editing for that share. Users clicking on the link thought nextcloud/ONLYOFFICE was broken oder malfunctioning since the sharing user said the document can be edited.

This is related to #19489.

@loelkes loelkes added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels May 2, 2020
@kesselb
Copy link
Contributor

kesselb commented May 2, 2020

https://github.com/ONLYOFFICE/onlyoffice-nextcloud/ should be the right repository for such a request because the button is added by their app to the public sharing page: https://github.com/ONLYOFFICE/onlyoffice-nextcloud/blob/f9e427ea53866568271a950c27343ca0ebee8aae/js/main.js#L365-L368

@ghost
Copy link

ghost commented Jun 2, 2020

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Ticket or PR with no recent activity label Jun 2, 2020
@ghost ghost closed this as completed Jun 16, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement integration needs info stale Ticket or PR with no recent activity
Projects
None yet
Development

No branches or pull requests

2 participants