Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Option to hide download link of shared media #2085

Closed
oeves opened this issue Nov 10, 2016 · 5 comments
Closed

Feature Request: Option to hide download link of shared media #2085

oeves opened this issue Nov 10, 2016 · 5 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: files feature: sharing

Comments

@oeves
Copy link

oeves commented Nov 10, 2016

We are sharing a lot of small videos (h264 mp4) and the player works very well.

It would be nice to have the option of hiding the download link for selected files to offer only the media player.

@nickvergessen
Copy link
Member

Hiding the button is easy. However the link itself will still work, because the player uses the exact same endpoint. So we could only pseudo fix this.

@oeves
Copy link
Author

oeves commented Nov 14, 2016

The pseudo fix sounds perfect. That the file is still downloadable "if you know how" is not a problem i think, because it is also possible to download files from YouTube/Vimeo/etc with the right knowledge for example.

@MorrisJobke
Copy link
Member

I would vote against this. Adding more and more special options for shares doesn't make it easier. What do you think, @jancborchardt and @karlitschek?

@MorrisJobke MorrisJobke added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Jan 25, 2017
@karlitschek
Copy link
Member

I agree. Let's not make another option for something that is mainly cosmetic.

@jancborchardt
Copy link
Member

Yep. What we could do is improve the design of the share view to make the viewer more the focal point, and the download / link area less prominent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: files feature: sharing
Projects
None yet
Development

No branches or pull requests

5 participants