Unable to load the shares list - ShareAPIController::getDisplayNameFromAddressBook() must be of the type string, null returned #21645
Comments
tkolo
added
0. Needs triage
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@tkolo does it still happens? I cannot reproduce the issue 🤔 |
|
Yes, I can still reproduce it on my instance, Nextcloud 19.0.1 |
|
Can you dump your addressbook table there please? |
|
there you go, dumped as CSV via pgadmin4: The user from share in question probably comes from address book with ID 3 |
@georgehrke that is weird, right? |
I have never seen this before. |
|
I've masked the external cloud's URI for privacy purposes if that's what you're referring to. |
Not really. It's just a bit weird. You're using federated clouds? |
|
Yes, I've tried to share a file to a cloud user from another instance. |
Have you linked two instances together or just shared to another instance? |
|
I've mutually added them as "trusted servers", does that count as "linking"? |
yes, But you don't need to do this to share a file to an external cloud. |
|
I know, the idea was to actually have auto completion for sharing, I believe that's what this is for |
|
@tkolo please edit the // private function getDisplayNameFromAddressBook(string $query, string $property): string {
$logger = \OC::$server->getLogger();
$logger->error(json_encode(['getDisplayNameFromAddressBook', $query, $property]));Then trigger the error again, and check the logs for the |
|
There you go: In case it's relevant, I don't mind sharing these logs "uncensored", just not in publicly visible and forever archived issue on github... |
No it's all good! if ($value === $query && $r['FN']) { |
|
That fixed the issue. |
|
Awesome! Let me provide a fix :) |
skjnldsv
added
1. to develop
How to use GitHub
Steps to reproduce
I've only tried once so the expected steps might not be exact
Expected behaviour
Shares should open
Actual behaviour
There's an exception thrown in nextcloud
Server configuration
Operating system: Ubuntu 18.04
Web server: Nginx 1.17.8
Database: PostgreSQL 12.2 (Ubuntu 12.2-2.pgdg18.04+1)
PHP version: PHP 7.4.4 (fpm-fcgi)
Nextcloud version: (see Nextcloud admin page) 19.0.0, also tried on 18.0.6
Updated from an older Nextcloud/ownCloud or fresh install: updated from 18.0.6 to 19.0.0, both show exact same behavior
Where did you install Nextcloud from: downloaded tarball from official nextcloud site
Signing status:
Signing status
No errors have been found.
List of activated apps:
App list
Nextcloud configuration:
Config report
Are you using external storage, if yes which one: local/smb/sftp/...
none
Are you using encryption: yes/no
no, neither e2e nor full disk encryption provided by nextcloud
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
none
Client configuration
Browser:
Mozilla/5.0 (X11; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0
Operating system:
Arch Linux
Logs
Web server error log
Web server error log
Nextcloud log (data/nextcloud.log)
Nextcloud log
Browser log
Browser log
All related network logs:
Console log:
The text was updated successfully, but these errors were encountered: