Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard empty state improvements and unification #22339

Closed
4 of 7 tasks
jancborchardt opened this issue Aug 20, 2020 · 5 comments
Closed
4 of 7 tasks

Dashboard empty state improvements and unification #22339

jancborchardt opened this issue Aug 20, 2020 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: dashboard
Milestone

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Aug 20, 2020

There are some outstanding improvements for the empty states:

  • For every widget: Since we have a bold heading for each widget already, it’s a bit much to set the emptycontent text as h2 as well. I’d say we should instead set it as a simple <p>.
  • Recommended files: Doesn’t show anything, should show the files icon and "No recommendations yet". cc @juliushaertl
  • Mail: The image is a bit out of place, should use an icon instead. cc @ChristophWurst @GretaD
    • When no accounts are set up: icon-archive from Mail, and text "No accounts configured".
    • When accounts are set up but there’s no important mails: icon-checkmark, "No important mails". If there are any other mails, we could also have that message be only 2 entries high and show other mails below like we do in Talk.
  • Calendar: Is great regarding text and position, but the "Create a new event" button does nothing. Also the text should be set as <p> as said above, and icon-checkmark would be better as icon (also to not duplicate the calendar icon). cc @georgehrke
  • Talk: Is great on icon and text (when it’s shortened), but if there are no conversations yet it’s strange to have it stick to the top. It would be better to have it vertically centered, and also to have a button "Start a conversation". cc @nickvergessen => Better empty content on dashboard spreed#4033
. .
image image
@jancborchardt jancborchardt added enhancement 1. to develop Accepted and waiting to be taken care of feature: dashboard labels Aug 20, 2020
@jancborchardt jancborchardt added this to the Nextcloud 20 milestone Aug 20, 2020
@georgehrke
Copy link
Member

Calendar: Is great regarding text and position, but the "Create a new event" button does nothing.

I simply didn't implement it yet. That PR is still a draft after all :)

@nickvergessen
Copy link
Member

Talk: Is great on icon and text (when it’s shortened), but if there are no conversations yet it’s strange to have it stick to the top. It would be better to have it vertically centered, and also to have a button "Start a conversation".

Talk is not empty on first visit, as you have the changelog conversation and in the future the notes conversation, you just removed everything but that is not the default. 😉 I think the logic in the vue component is currently quite bound to load the conversation afterwards and being on the talk UI, so not sure it makes too much sense to invest a lot of time into this when it only shows when you intentionally clear all conversations.

For the positioning, the current positioning is chosen, as we will show conversations without calls/mentions if you have no calls/mentions at all. So again, this only looks like this when you intentionally go to talk and make it look like this. Can we spent time better or is this a must have for people wanting to break things?

@jancborchardt
Copy link
Member Author

@nickvergessen ok, sure – probably a bit convoluted. Still for Talk: Could you shorten the message to just "No unread mentions" as well as setting it as a <p> instead of a <h2>?

@nickvergessen
Copy link
Member

I thought I had done that already, let me check

@juliushaertl
Copy link
Member

Closing as the core apps have been fixed and other issues should be tracked in the individual app repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: dashboard
Projects
None yet
Development

No branches or pull requests

4 participants