-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard empty state improvements and unification #22339
Comments
I simply didn't implement it yet. That PR is still a draft after all :) |
Talk is not empty on first visit, as you have the changelog conversation and in the future the notes conversation, you just removed everything but that is not the default. 😉 I think the logic in the vue component is currently quite bound to load the conversation afterwards and being on the talk UI, so not sure it makes too much sense to invest a lot of time into this when it only shows when you intentionally clear all conversations. For the positioning, the current positioning is chosen, as we will show conversations without calls/mentions if you have no calls/mentions at all. So again, this only looks like this when you intentionally go to talk and make it look like this. Can we spent time better or is this a must have for people wanting to break things? |
@nickvergessen ok, sure – probably a bit convoluted. Still for Talk: Could you shorten the message to just "No unread mentions" as well as setting it as a |
I thought I had done that already, let me check |
Closing as the core apps have been fixed and other issues should be tracked in the individual app repos. |
There are some outstanding improvements for the empty states:
<p>
.icon-archive
from Mail, and text "No accounts configured".icon-checkmark
, "No important mails". If there are any other mails, we could also have that message be only 2 entries high and show other mails below like we do in Talk.<p>
as said above, and icon-checkmark would be better as icon (also to not duplicate the calendar icon). cc @georgehrkeThe text was updated successfully, but these errors were encountered: