Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade internal S3 library #2315

Closed
flypenguin opened this issue Nov 24, 2016 · 13 comments
Closed

Upgrade internal S3 library #2315

flypenguin opened this issue Nov 24, 2016 · 13 comments
Labels
Milestone

Comments

@flypenguin
Copy link

#60 is closed now, but the internal S3 lib is too old to support all AWS regions because of v2 vs. v4 authentication mechanisms.

So please upgrade the internal S3 connection lib to enable all regions (e.g. Frankfurt).

(ref: #768 (comment))

@MariusBluem
Copy link
Member

Is this something still possible with Nextcloud 11? @rullzer @icewind1991

@LukasReschke LukasReschke removed the high label Nov 24, 2016
@LukasReschke
Copy link
Member

Doubt it. 12 at earliest. (aka early next year)

@rullzer
Copy link
Member

rullzer commented Nov 24, 2016

I wouldn't risk doing that for 11. But makes sense to do it early in the 12 cycle.

@MariusBluem
Copy link
Member

Because this is blockig S3 for AWS in Frankfurt I think this is important 😁😅

@jospoortvliet jospoortvliet added this to the Nextcloud 12.0 milestone Dec 8, 2016
@MariusBluem
Copy link
Member

Is v2 (the current implemenetation) still supported and "secure" if we are talking about authentification ;)

@8BitAce
Copy link

8BitAce commented Apr 19, 2017

Has the AWS PHP SDK changed that significantly over this time period? Or is this something that someone with only basic understanding of nexcloud app structuring can pick up?

@icewind1991
Copy link
Member

Updated the sdk in #4410

Please spend some time testing the various s3 integrations (not with production data ofc)

@MorrisJobke
Copy link
Member

Out of scope for 12 -> move to 13

@flypenguin
Copy link
Author

MEH. Was hoping I could move my files into S3 now.
Any timeline for 13?

@MorrisJobke
Copy link
Member

Any timeline for 13?

~5-6 months after 12 I would say roughly.

@icewind1991
Copy link
Member

#4410 should be ready for review.

Any help testing the changes would be greatly appreciated (and helps make sure they actually get merged 😄 )

@flypenguin
Copy link
Author

one remark, even if maybe this is already present: it would be nice, at least in some future, that you could use AWS server side encryption for S3 objects as well. is that being done / considered or should I create another ticket?

ref: http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingServerSideEncryption.html

@MorrisJobke
Copy link
Member

Fixed with #4410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants