Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English (Denmark) locale uses wrong date/time format #24134

Open
haarp opened this issue Nov 14, 2020 · 13 comments
Open

English (Denmark) locale uses wrong date/time format #24134

haarp opened this issue Nov 14, 2020 · 13 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 25-feedback bug feature: language l10n and translations needs review Needs review to determine if still applicable

Comments

@haarp
Copy link

haarp commented Nov 14, 2020

The en_DK locale has always been a clever workaround for the lack of a proper locale that features:

  • English
  • Sane date format - ISO8601 (yyyy-mm-dd)
  • 24h time
  • week starting on Monday

Proof:

$ LC_TIME=en_US.UTF-8 date
Sat Nov 14 04:31:38 PM CET 2020
$ LC_TIME=en_DK.UTF-8 date
2020-11-14T16:31:41 CET

(Fun fact: This locale has nothing to do with Denmark, see https://unix.stackexchange.com/a/272665)

Selecting the English (Denmark) locale in Nextcloud 19.04.4 however gives you inferior mm/dd/yyyy and 12h time. This is undoubedly a bug.

#15381 is related. #15457 and #14785 are NOT related, as this issue isn't about language, but date/time formats.

Thanks!

Server configuration

Operating system:
Debian Linux 10

Web server:
Apache 2.4.38-3+deb10u4

Database:
MariaDB 10.3.25-0+deb10u1

PHP version:
7.3.19-1~deb10u1

Nextcloud version: (see Nextcloud admin page)
19.0.4

Updated from an older Nextcloud/ownCloud or fresh install:
updated

Where did you install Nextcloud from:
integrated auto-installer/updater

Signing status:
No errors have been found.

Nextcloud configuration:

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "nope"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/nextcloud.erppc.net\/",
        "overwritewebroot": "\/",
        "htaccess.RewriteBase": "\/",
        "dbtype": "mysql",
        "version": "19.0.4.2",
        "knowledgebaseenabled": false,
        "apps_paths": [
            {
                "path": "\/var\/www\/nextcloud\/apps",
                "url": "\/apps",
                "writable": true
            }
        ],
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "loglevel": 2,
        "mail_smtpmode": "sendmail",
        "theme": "",
        "maintenance": false,
        "trashbin_retention_obligation": "auto",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "session_lifetime": 86400,
        "mysql.utf8mb4": true,
        "updater.release.channel": "stable",
        "preview_max_x": "2048",
        "preview_max_y": "2048",
        "preview_max_filesize_image": 100,
        "app_install_overwrite": [
            "checksum"
        ]
    }
}

Client configuration

Browser:
Firefox 82.0.2

Operating system:
Linux

@haarp haarp added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Nov 14, 2020
@haarp haarp changed the title Denmark locale uses wrong date/time format English (Denmark) locale uses wrong date/time format Nov 14, 2020
@szaimen
Copy link
Contributor

szaimen commented Jun 17, 2021

Is this Issue still valid in NC21.0.2? If not, please close this issue. Thanks! :)

@haarp
Copy link
Author

haarp commented Jun 17, 2021

Is this Issue still valid in NC21.0.2? If not, please close this issue. Thanks! :)

Yes. In 21.0.2:

06/17/2021 8:13:06 PM

Week starts on Monday

@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of feature: language l10n and translations and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jun 17, 2021
@rigrig
Copy link
Contributor

rigrig commented Oct 27, 2022

Still an issue in 25.0.0:
image

@asavah
Copy link

asavah commented Nov 3, 2022

Many english locales are wrong.
English (europe) uses mm/dd/yyyy format, which is NOT used anywhere in Europe.
The developers should be aware that at least some English speaking people are not from America,
and that fixing bugs which were open for years might be a good thing.

@szaimen
Copy link
Contributor

szaimen commented Jan 23, 2023

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 23, 2023
@rigrig
Copy link
Contributor

rigrig commented Jan 23, 2023

Still an issue:
image

image

@artonge
Copy link
Contributor

artonge commented Feb 21, 2023

Seems like it is due to moment.js not having a comprehensive list of locales. The solution would be to move to another date library that rely on the Intl API.

@szaimen
Copy link
Contributor

szaimen commented Feb 21, 2023

The solution would be to move to another date library that rely on the Intl API.

sounds good to me

@adripo
Copy link

adripo commented Mar 1, 2023

I confirm that the issue is still present in latest 24.0.10 version.
Also English(Ireland) has wrong configuration. Week starts on Sunday instead of Monday.
image

@adripo
Copy link

adripo commented Mar 1, 2023

@szaimen FYI moment.js development is being stopped.

As they are suggesting, maybe we don't need moment.js anymore

@lyallp
Copy link

lyallp commented Jun 14, 2023

Nextcloud 25.0.3 and Calendar 4.4.2 still exhibit this behaviour, as in shows Sunday as the left column in the calendar, when first day of week is Monday (English - Australia)

@bendev25689
Copy link

bendev25689 commented Jun 27, 2023

Nextcloud 26.0.2. Denmark locale is still wrong.
Australian locale is also still wrong. We start the week on monday. Source: https://www.timeanddate.com/calendar/days/first-day-of-the-week.html
An interface such as the one in synology calendar would be ideal:
image

@jm355
Copy link

jm355 commented Feb 10, 2024

This still seems to be an issue, nextcloud 28.0.2.5

@joshtrichards joshtrichards added the needs review Needs review to determine if still applicable label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 25-feedback bug feature: language l10n and translations needs review Needs review to determine if still applicable
Projects
None yet
Development

No branches or pull requests

10 participants