-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve overall Nextcloud Search experience #29614
Comments
In addition we should consider always showing the current search input then if some local filtering applies, otherwise users might be confused by a filtered view when there is no clear indication where to reset or change that filter. |
This comment has been minimized.
This comment has been minimized.
The second change proposed deals with the suggestion in #27078 |
Very good proposal. :) Only question is, how sophisticated and complex could be the modal filters? But probably this is another issue to address. |
Q. isn't the slow performance directly related to the number of items (in the file search at least)? If so while "de-universalising" the output is great for non-files search, how does it improve performance for file search (which I'd guess was the most common requirement for search outside of Deck-heavy installs) |
Copy/pasting my thoughts on #29989, inappropriately marked as duplicate:
|
Yes, but this isn't a regression - search for all files became no slower since the introduction of universal search. If anything, it got faster. But much of the time you want to filter in the current folder, and suddenly you always had to wait for the full search. which is fixed with 23 already. With my proposal we lower the server load from search and focus on the common case of app-specific search. That does indeed not fix slow all-files search. |
Adding this #30311 here as it also improves it in some way. |
@jospoortvliet For us the universal search meant a huge regression. In the last couple of versions we always hat to deactivate the file search on code level. |
I'll be working on search modals for the next month and a half, I'll have more info then on how difficult it is : https://help.nextcloud.com/t/looking-forward-to-develop-sorts-files-visualisation-improvement-and-filters/128314 |
Hi @Aeredren any update perhaps? |
Just want to reference #35776 (comment) which shows an alternative approach by @Mer0me. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Let's focus on the UI side of this, possible performance or search backend integration should be a different issue. |
I think full screen is preferred. As one could potentially have thousands or tens of thousands or more files, and search result count could be any number, full screen would be better suited. The filter buttons in your screen shot could be moved to some sidebar similar to categories in Settings. Concerning the previous comment about search performance, such I think goes together and was part of the original comment for this issue. Think of any search of any large web site, database, or desktop/mobile app (e.g. contacts, mail, calendar, tasks, music, etc.), none use LIKE searches. Isn't it about time Nextcloud also abandons such? |
closing in favor of #39162 |
Hi,
Right now, we have a few issues with the search, some of the main ones are:
To deal with this, we now have a work-around in the app store and Files app, as well as in Deck.
Files and the app store have implemented a filter in the UI, showing search results there while the universal search pop-up is still doing its thing:
Deck just implemented a second, direct search:
Discussing it today with Andy, perhaps there is a good way we can solve all three problems in one.
We make 2 changes:
Best part is that this is probably not too crazy much work.
What do you think, @nextcloud/designers ?
The text was updated successfully, but these errors were encountered: