Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Swiftmailer to Symfony Mailer #29731

Closed
come-nc opened this issue Nov 16, 2021 · 0 comments · Fixed by #30349
Closed

Migrate from Swiftmailer to Symfony Mailer #29731

come-nc opened this issue Nov 16, 2021 · 0 comments · Fixed by #30349
Assignees
Labels
2. developing Work in progress
Milestone

Comments

@come-nc
Copy link
Contributor

come-nc commented Nov 16, 2021

We currently use https://github.com/swiftmailer/swiftmailer which is stopping development at the end of November and advising to move to Symfony Mailer.

There are rectors for this but I did not manage to get them to work on our code as-is:
https://github.com/rectorphp/rector-symfony/blob/main/config/sets/swiftmailer/swiftmailer-to-symfony-mailer.php
https://github.com/rectorphp/rector-symfony/blob/main/src/Rector/MethodCall/SwiftSetBodyToHtmlPlainMethodCallRector.php

Switching from \Swift_Message to \Symfony\Component\Mime\Email is pretty straightforward and should not affect our public interfaces in \OCP\Mail.
The transport part may be less straightforward, but both sendmail and smtp are supported by symfony mailer.

@come-nc come-nc added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 16, 2021
@come-nc come-nc added this to the Nextcloud 24 milestone Nov 16, 2021
@come-nc come-nc mentioned this issue Dec 20, 2021
52 tasks
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@come-nc come-nc self-assigned this Oct 10, 2022
@come-nc come-nc added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Oct 10, 2022
@come-nc come-nc modified the milestones: Nextcloud 25, Nextcloud 26 Oct 10, 2022
@ChristophWurst ChristophWurst moved this to 📄 To do (~10 entries) in 💌 📅 👥 Groupware team Nov 30, 2022
@ChristophWurst ChristophWurst moved this from 📄 To do (~10 entries) to 🏗️ In progress in 💌 📅 👥 Groupware team Jan 18, 2023
@ChristophWurst ChristophWurst assigned miaulalala and unassigned come-nc Jan 18, 2023
@szaimen szaimen removed the bug label Jan 23, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
Development

Successfully merging a pull request may close this issue.

5 participants