Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F2V] Migrate tags view #30249

Closed
4 of 11 tasks
skjnldsv opened this issue Dec 13, 2021 · 3 comments · Fixed by #40475
Closed
4 of 11 tasks

[F2V] Migrate tags view #30249

skjnldsv opened this issue Dec 13, 2021 · 3 comments · Fixed by #40475
Assignees
Milestone

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Dec 13, 2021

This ticket is part of the files to vue migration

Goal

Unify and improve the system tags view

QA

  • Display tags as folders (new API ⚠️)
    • Implementing this as a DAV might give us opportunity to directly catch DELETE/PUT/MOVE requests
      BUT it will create issues with the paths considering a file located in dav/USER/files/Photos/vacation.jpg will be seen with a path like dav/USER/tags/Summer 2021 vacations/vacation.jpg while all the actions would expect the real dav path to work 🤔
    • Implementing this with OCS API will allow us to return different data like path that fixes the issue above
  • Opening the tag (folder) list all files belonging to it
  • Actions
    • Rename
    • Delete
    • There is no sidebar for those tags/fake-folders, we need to check how to handle this ⚠️
  • Assess this global way of managing this. Considering it will use the same API as the real Files/Folders: [F2V] Files views API + navigation + base structure #30070, check potential pitfalls of storing and caching "fake folders".
    • Actions might be displayed while not theoretically supporting it on those folders

Future

  • Show most recent/used tags in the navigation same as favorites
@skjnldsv skjnldsv added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 13, 2021
@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Dec 13, 2021
@icewind1991
Copy link
Member

BUT it will create issues with the paths considering a file located in dav/USER/files/Photos/vacation.jpg will be seen with a path like dav/USER/tags/Summer 2021 vacations/vacation.jpg while all the actions would expect the real dav path to work thinking

Given that the same problem would exist for other dav views, it probably makes sense to have the view expose some form of "canonical path" to give apps the "expected" path

@skjnldsv
Copy link
Member Author

Given that the same problem would exist for other dav views, it probably makes sense to have the view expose some form of "canonical path" to give apps the "expected" path

Well, the main issue is not about display, but about the context passed to the actions for example.
If I display a list of files in https://cloud.domain.com/apps/files/tags/Tagged-folder/file.ext, then the actions for a file should still apply to https://cloud.domain.com/remote.php/dav/user/files/path/to/file.ext
But I guess you can list files with ocs fine, and it can provide different paths. But we need to be careful about potential pitfalls 🤔

@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@Spartachetto
Copy link

I do not see in the action list for the "virtual folders" defined by tags the possibility to share all the tagged files with one action. This functionality has been asked several times. If needed I can link the issues that ask for it.

@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Oct 19, 2022
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@ShGKme ShGKme self-assigned this Aug 8, 2023
@skjnldsv skjnldsv mentioned this issue Aug 16, 2023
26 tasks
@skjnldsv skjnldsv assigned skjnldsv and unassigned ShGKme Sep 17, 2023
@skjnldsv skjnldsv removed the 1. to develop Accepted and waiting to be taken care of label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants