File Delete Confirmation Dialog

[HaziFlorinMarian]

Is your feature request related to a problem? Please describe.
When we right-click on the files we have the last two options from the "Download" and "Delete" list. It is very common for our users to click "Delete" instead of "Download" and the files are deleted directly.

Describe the solution you'd like
When we click on "Delete" a popup window will open asking us to confirm if we really want to delete.

Describe alternatives you've considered
The "Download" and "Delete" buttons are no longer below each other.

Additional context
It's not necessary.

[szaimen]

Cc @nimishavijay @jancborchardt

[killerbees19]

A confirmation dialog is as much more important if files_versions app is disabled!

Please implement such a feature at minimum as optional (configurable) setting.

[giang13297]

Hi Guys,
Any update for this feature.
Please!!!!

[delacosta456]

hi
i also want to request for this feature and mention that people have also requested for it on forums.
Is it also possible to rename the title of this feature request to something like "Confirmation Dialog for files & folder deletion"
Thanks

[nimishavijay]

Interesting problem! One Drive and Dropbox have a confirmation dialogue for deleting files too. However, it seems intrusive to show a confirmation dialogue every time a file is deleted, since deletion is a common action. There is also a trash bin from which files can be recovered.

We could definitely move the "Download" action up. Another solution is to have a notification with an undo button, similar to sending a message in Mail. This is also the behaviour for Google Drive. So a notification Design review.md has been deleted. [Undo]. This would be my preferred solution as it is not as intrusive, and still offers a way to quickly cancel deletion if it was by mistake. What do you think? cc @jancborchardt and @szaimen as well

[szaimen]

@nimishavijay I agrees that an undo popup would be the preferred solution in that case since showing a popup might be too intrusive and slow and as you said we have the trashbin for this case.

However maybe there could be a differentiation between folders and files? So that to show the popup for folders and/or if multi-selecting and then clicking on the delete option?

[killerbees19]

There is also a trash bin from which files can be recovered.

In some cases this feature is disabled, because it's nearly incompatible with external files storage and big files. (See #14436 or #18396)

[delacosta456]

hi @nimishavijay intrusive... truly and if your are talking about deleting multiple files, selecting concerned files/folder with check box method(already present) could present a single confirmation box about select items.
Also, i think Gmail has a setting to configure (enable) "Confirm before deleting.." may be implementing this (if possible) could let the user decide what is comfortable .

[skjnldsv]

@nimishavijay @szaimen @jancborchardt
What about showing a confirm if you are deleting more than one file ?

That would be a sane compromise to move that issue forward I think? :)

[szaimen]

@nimishavijay @szaimen @jancborchardt What about showing a confirm if you are deleting more than one file ?

That would be a sane compromise to move that issue forward I think? :)

Yes, sounds like a good solution to me :)

[jancborchardt]

@skjnldsv yup, sounds like a good first step. :)

[LMRW]

If trash & file versions are disabled (which sometimes is required) then being able to delete entire folders of terabytes of data in a single click without confirmation is a HUGE issue. Absolutely nextcloud should ask users if they are sure - every time - if trash can and versions are disabled. This is a massive massive massive usability issue with tremendous danger of incredible file loss.

[BloodyIron]

If trash & file versions are disabled (which sometimes is required) then being able to delete entire folders of terabytes of data in a single click without confirmation is a HUGE issue. Absolutely nextcloud should ask users if they are sure - every time - if trash can and versions are disabled. This is a massive massive massive usability issue with tremendous danger of incredible file loss.

You might have missed this in the history of this issue -> #43231

Not yet sure what version of nextCloud it comes in though. I'm checking currently.

[BloodyIron]

Looks like it made it into v29.0.0-beta1, so prettttyyyy sure it's in RELEASE v29.x : https://github.com/nextcloud/server/releases/tag/v29.0.0beta1

[BloodyIron]

Er wait hold on... is there no delete confirmation in v29 for a single file delete instruction? :s

[skjnldsv]

No, there is if you delete more than X items at a time. The idea of also asking for confirmation for folder bigger than X GB is pretty nice too.

But if files_trashbin is disabled, I think we should always ask for confirmation, I agree.

@jancborchardt @nimishavijay ?

[BloodyIron]

I for one would really want a setting to just ask every time anyways, even if you can toggle it off. Having to go to the trashbin because... OOPS I clicked delete instead of download... is now a waste of time to retrieve it, that could have easily been avoided by an "Are you sure?". To me that I think enables a happy medium for all. I actually can't even fathom why this change even required a minimum # to activate in the first place, that seems very out of place.

[LMRW]

For people with no trash bin (pretty much essential for files_external) there is still a giant risk of deleting literally terabytes in a single click of a button which starts with the same letter as, and sits right alongside, the Download button.

It's absolutely horrifying to be honest and makes nextcloud completely unusable for large teams where accidents can happen!

Can't we just please have a setting in admin to alert users to confirm deleting files? That seems to be a simple solution, and pretty much every single operating system and cloud service already does this!

With all that said, thank you for the start in a right direction with what we have so far -- at least it's better than before (although I would say still not enough)

[BloodyIron]

Oh and to clarify, I really think there should be no minimum number of selected items for an "Are you sure?" dialogue. Right clicking on a file to delete/download is precariously close together. This is completely avoidable as a problem. Whether trash exists or not.

[LMRW]

I love nextcloud and I'm so grateful but I have to be honest it's so crazy and confusing to me this is even debated... if trash can is disabled, confirm every single delete.

[skjnldsv]

if trash can is disabled, confirm every single delete.

this part is definitely not debated, I'll take care of it asap ! :)