Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phone region code in install wizard #32613

Open
mat-m opened this issue May 26, 2022 · 0 comments
Open

Add phone region code in install wizard #32613

mat-m opened this issue May 26, 2022 · 0 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: install and update papercut Annoying recurring issue with possibly simple fix.

Comments

@mat-m
Copy link

mat-m commented May 26, 2022

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

default_phone_region is in the sample config. It says there is no defaults. So I removed it.

Sanity check reported it with a Warning:

Your installation has no default phone region set. This is required to validate phone numbers in the profile settings without a country code. To allow numbers without a country code, please add "default_phone_region" with the respective [ISO 3166-1 code ↗](https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2#Officially_assigned_code_elements) of the region to your config file.

So we can't get the green check mark without the setting applied.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Since it raises a warning, but it can't have a default value (at least the sample told), it deserves a text field in the installation wizard,
with the same link to the wikipdia page

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

  • Define a default value, but it seems rejected from the comment in the sample config file
  • Have a drop-down with the table code, but it seems there is no webservice available for this.

Additional context
Add any other context or screenshots about the feature request here.

@mat-m mat-m added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels May 26, 2022
@joshtrichards joshtrichards added the papercut Annoying recurring issue with possibly simple fix. label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: install and update papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

No branches or pull requests

2 participants