Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use large border-radius in AppNavigation #33431

Closed
jancborchardt opened this issue Aug 2, 2022 · 4 comments
Closed

Use large border-radius in AppNavigation #33431

jancborchardt opened this issue Aug 2, 2022 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement
Milestone

Comments

@jancborchardt
Copy link
Member

Just like done in the components: nextcloud-libraries/nextcloud-vue#2571
This needs to be adjusted in Files and Settings core styles as well, because otherwise they will look out of place in Nextcloud 25.

cc @marcoambrosini @PVince81 @GretaD

For reference here’s this screenshot by @raimund-schluessler:
image

@jancborchardt jancborchardt added enhancement design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of labels Aug 2, 2022
@jancborchardt jancborchardt added this to the Nextcloud 25 milestone Aug 2, 2022
@jancborchardt
Copy link
Member Author

@CarlSchwan since you are working on porting a lot of the Settings stuff to Vue: Do you think it makes sense to just port the nav(s) of Settings and Files as well instead of adjusting the legacy styles?

@CarlSchwan
Copy link
Member

@CarlSchwan since you are working on porting a lot of the Settings stuff to Vue: Do you think it makes sense to just port the nav(s) of Settings and Files as well instead of adjusting the legacy styles?

I was thinking about it too, worth a try at least for Settings it should be doable. Also, something that could be done and suggested by @nickvergessen this morning is to auto-scroll to the selected setting. I'll see that I can do ;)

@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Oct 19, 2022
@szaimen
Copy link
Contributor

szaimen commented Mar 8, 2023

I think this is done in the meantime?

@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@jancborchardt
Copy link
Member Author

Yes this was done with Nextcloud 25 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement
Projects
None yet
Development

No branches or pull requests

4 participants