-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache quota for 60 seconds #33553
Comments
ping @CarlSchwan because we talked about it |
context was: ViewController is querying quota stuff to be able to populate the UI somehow, need to check the detail there was a bug where ViewController was triggering the same event 3-4 times which caused apps to also query more stuff, perhaps also quota, this was handled in #33547 |
in https://github.com/nextcloud-gmbh/server/issues/511 we have ideas to remove the quota population in ViewController by using the one from PROPFIND |
this is the expensive bit when checking used space: https://github.com/nextcloud/server/blob/master/lib/private/Files/FileInfo.php#L379 because it includes all mount points and it also computes the etag from all mount points, we probably don't want to cache the latter ? it's triggered in:
so three times within a page load of files app at least |
@icewind1991 thoughts on where to cache ? it seems there is no good location to cache it at all, and also it might mean querying the memcache factory from inside the FileInfo I was thinking of maybe caching the submounts in FileInfo::updateEntryfromSubmounts. |
the caching has already been implemented: #32048 |
Check how to cache quota for 60 seconds, trade-off could be to just do this in the webUI and just do it for the left sidebar info.
Still check if applicable in other places on webUI.
The text was updated successfully, but these errors were encountered: