First email notification link wrong

[fpamelard]

Dear NextCloud team,

We've got a NextCloud instance into a subdomain mysub.mydomain.com. I've checked the config.php and everything seems good.
However, the first email for a new member refers to a link with mysub..mydomain.com (double dots).

Is there a way to fix it?

Regards,
Fabien

[nickvergessen]

Can you post the content or a screenshot of the email (domain is not needed) so we can know where to look at?

[fpamelard]

Here is

[nickvergessen]

Email in question:

server/apps/settings/lib/Mailer/NewUserMailHelper.php

Lines 99 to 162 in 3b65644

	public function generateTemplate(IUser $user, $generatePasswordResetToken = false) {
	$userId = $user->getUID();
	$lang = $this->l10nFactory->getUserLanguage($user);
	$l10n = $this->l10nFactory->get('settings', $lang);
	if ($generatePasswordResetToken) {
	$token = $this->secureRandom->generate(
	21,
	ISecureRandom::CHAR_ALPHANUMERIC
	);
	$tokenValue = $this->timeFactory->getTime() . ':' . $token;
	$mailAddress = (null !== $user->getEMailAddress()) ? $user->getEMailAddress() : '';
	$encryptedValue = $this->crypto->encrypt($tokenValue, $mailAddress . $this->config->getSystemValue('secret'));
	$this->config->setUserValue($user->getUID(), 'core', 'lostpassword', $encryptedValue);
	$link = $this->urlGenerator->linkToRouteAbsolute('core.lost.resetform', ['userId' => $user->getUID(), 'token' => $token]);
	} else {
	$link = $this->urlGenerator->getAbsoluteURL('/');
	}
	$displayName = $user->getDisplayName();
	$emailTemplate = $this->mailer->createEMailTemplate('settings.Welcome', [
	'link' => $link,
	'displayname' => $displayName,
	'userid' => $userId,
	'instancename' => $this->themingDefaults->getName(),
	'resetTokenGenerated' => $generatePasswordResetToken,
	]);
	$emailTemplate->setSubject($l10n->t('Your %s account was created', [$this->themingDefaults->getName()]));
	$emailTemplate->addHeader();
	if ($displayName === $userId) {
	$emailTemplate->addHeading($l10n->t('Welcome aboard'));
	} else {
	$emailTemplate->addHeading($l10n->t('Welcome aboard %s', [$displayName]));
	}
	$emailTemplate->addBodyText($l10n->t('Welcome to your %s account, you can add, protect, and share your data.', [$this->themingDefaults->getName()]));
	if ($user->getBackendClassName() !== 'LDAP') {
	$emailTemplate->addBodyText($l10n->t('Your username is: %s', [$userId]));
	}
	if ($generatePasswordResetToken) {
	$leftButtonText = $l10n->t('Set your password');
	} else {
	$leftButtonText = $l10n->t('Go to %s', [$this->themingDefaults->getName()]);
	}
	$clientDownload = $this->config->getSystemValue('customclient_desktop', 'https://nextcloud.com/install/#install-clients');
	if ($clientDownload === '') {
	$emailTemplate->addBodyButton(
	$leftButtonText,
	$link
	);
	} else {
	$emailTemplate->addBodyButtonGroup(
	$leftButtonText,
	$link,
	$l10n->t('Install Client'),
	$clientDownload
	);
	}
	$emailTemplate->addFooter('', $lang);
	return $emailTemplate;
	}

[fpamelard]

Yes, but seems there is an issue with the absoluteURL

[joshtrichards]

Hi @fpamelard - Can you provide your config (i.e. output of ./occ config:list system) so we can try to reproduce this?

Since your issue was created in a different repo initially it may have bypassed the normal bug report form. Some other bits of info might be useful too (you can see what's normally requested here: https://github.com/nextcloud/server/issues/new/choose), but your basic config may turn out to be sufficient.

[joshtrichards]

If willing, test PR #39607 to see if it fixes your situation.