New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getPublicCalendars in CalDAVBackend.php #34604

Open

tcitworld opened this issue Oct 14, 2022 · 0 comments

Labels

1. to develop feature: caldav technical debt tests

Member

tcitworld commented Oct 14, 2022

In fact we do not call getPublicCalendars anymore since #4224 and this method is only used in tests, so we don't really need to change it.

Well as it's still being used in the tests we can refactor them then remove it directly altogether. Even though the method is public it's kind of a private API, and I don't seem to find anywhere it's been used anyway.

Originally posted by @tcitworld in #34372 (comment)

tcitworld added 1. to develop technical debt feature: caldav labels

joshtrichards added the tests label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment