Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back 32 bit support on Nextcloud 26 #36072

Closed
19 of 20 tasks
PVince81 opened this issue Jan 10, 2023 · 11 comments · Fixed by #36120
Closed
19 of 20 tasks

Bring back 32 bit support on Nextcloud 26 #36072

PVince81 opened this issue Jan 10, 2023 · 11 comments · Fixed by #36120
Assignees
Milestone

Comments

@PVince81
Copy link
Member

PVince81 commented Jan 10, 2023

Tasks

Regarding the typing, instead of removing typing like for stable25 we should use the union types available thanks to PHP 8 and use int|float.

Running the CI on 32 bits is not that straightforward because Github does not propose it so one has to run a docker in a docker or something along these lines. Need someone with knowledge on CI/docker.

On Drone, 64bit hardware is likely able to run 32bit code.
See "arch" field in https://docs.drone.io/pipeline/configuration/

It should not be too hard to fix once we have proper CI, given we have the PR for stable25 to use as an example of how to fix stuff. That said it seems stable25 is still not passing test suite on 32bits.

Estimate: possibly 2 weeks effort if not more depending on hurdles and whether we need to port Github workflow tests to Drone

@AndyScherzinger @DaphneMuller @come-nc @blizzz

@PVince81
Copy link
Member Author

@come-nc can you update the status, in case there was progress on the revertings ?

@come-nc
Copy link
Contributor

come-nc commented Jan 24, 2023

Only reverted the first one in my PR, I checked the boxes with current PR state.

Current CI status in the PR:
Tests: 14429, Assertions: 37379, Errors: 8, Failures: 6, Warnings: 29, Skipped: 42.

On the 8 errors:

  • 7 are PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "OCA\Files_External\Lib\StorageConfig" does not exist from tests/lib/Encryption/UtilTest.php:208. They also fail in my 8.2 testing PR and should be fixed or skipped, but are not related to 32bits
  • 1 is ValueError: Epoch doesn't fit in a PHP integer from sabre-dav, needs investigation and fix or skip

On the 6 failures:

  • All 6 of them seem related to the routes loading failing for files application. From what I was able to debug the include_once in lib/private/Route/Router.php does not include the routes because the file was already included but the routes were lost for some reason. It only happens in github and not in drone or local run, and only happens when running apps/files tests after core tests. So some kind of env specific loading problem. Not related to 32bits. Not clear how to fix it and not sure if safe to skip routing tests on 32bits?

@come-nc come-nc added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jan 24, 2023
@come-nc
Copy link
Contributor

come-nc commented Jan 24, 2023

@szaimen
Copy link
Contributor

szaimen commented Feb 9, 2023

Looks like everything done now or is something missing?

@blizzz
Copy link
Member

blizzz commented Feb 9, 2023

Looks like everything done now or is something missing?

I am not aware of anything missing. @come-nc can you confirm?

@come-nc
Copy link
Contributor

come-nc commented Feb 9, 2023

Backport of CI and fixes to 25 is missing but that will have to wait 25.0.5.

@blizzz
Copy link
Member

blizzz commented Feb 9, 2023

Backport of CI and fixes to 25 is missing but that will have to wait 25.0.5.

which ones did i miss? (but this issue is about 26?)

@come-nc
Copy link
Contributor

come-nc commented Feb 13, 2023

Backport of CI and fixes to 25 is missing but that will have to wait 25.0.5.

which ones did i miss? (but this issue is about 26?)

The fixes which were done in the PR adding CI: #36120
The CI needs to be backported to 25 and some things will break, and some of the fixes will have to be backported.
But it’s not an easy backport because typing is different on 25 and 26.

@ZachHandley
Copy link

hey so, I don't know if this is the right issue, but I have this error
image
only on files over 2 GB, these aren't four, they're 3.7 GB, so it's extra weird. From the research I've done, it's related to #16431 -- if I'm wrong please don't re-open, but I can't upload anything and I have a hetzner cloud 32 bit so.

@AndyScherzinger
Copy link
Member

Can't say for sure @ZachHandley - best to raise a new issue so folks can reply to it. I know there is a limitation in terms of file size 32Bit can handle due to the limitations that come with it within PHP.

@sunjam
Copy link

sunjam commented Aug 4, 2024

hey so, I don't know if this is the right issue, but I have this error image only on files over 2 GB, these aren't four, they're 3.7 GB, so it's extra weird. From the research I've done, it's related to #16431 -- if I'm wrong please don't re-open, but I can't upload anything and I have a hetzner cloud 32 bit s

Try asking Hetzner assistance directly. Good luck with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants