-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back 32 bit support on Nextcloud 26 #36072
Comments
@come-nc can you update the status, in case there was progress on the revertings ? |
Only reverted the first one in my PR, I checked the boxes with current PR state. Current CI status in the PR: On the 8 errors:
On the 6 failures:
|
Looks like everything done now or is something missing? |
I am not aware of anything missing. @come-nc can you confirm? |
Backport of CI and fixes to 25 is missing but that will have to wait 25.0.5. |
which ones did i miss? (but this issue is about 26?) |
The fixes which were done in the PR adding CI: #36120 |
hey so, I don't know if this is the right issue, but I have this error |
Can't say for sure @ZachHandley - best to raise a new issue so folks can reply to it. I know there is a limitation in terms of file size 32Bit can handle due to the limitations that come with it within PHP. |
Try asking Hetzner assistance directly. Good luck with it. |
Tasks
Regarding the typing, instead of removing typing like for stable25 we should use the union types available thanks to PHP 8 and use
int|float
.Running the CI on 32 bits is not that straightforward because Github does not propose it so one has to run a docker in a docker or something along these lines. Need someone with knowledge on CI/docker.
On Drone, 64bit hardware is likely able to run 32bit code.
See "arch" field in https://docs.drone.io/pipeline/configuration/
It should not be too hard to fix once we have proper CI, given we have the PR for stable25 to use as an example of how to fix stuff. That said it seems stable25 is still not passing test suite on 32bits.
Estimate: possibly 2 weeks effort if not more depending on hurdles and whether we need to port Github workflow tests to Drone
@AndyScherzinger @DaphneMuller @come-nc @blizzz
The text was updated successfully, but these errors were encountered: