Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NcSelect are broken in dark mode with 25.0.4 rc1 #36676

Closed
szaimen opened this issue Feb 11, 2023 · 4 comments
Closed

NcSelect are broken in dark mode with 25.0.4 rc1 #36676

szaimen opened this issue Feb 11, 2023 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of 25-feedback bug high regression
Milestone
Nextcloud 25.0.5

Comments

@szaimen
Copy link
Contributor

szaimen commented Feb 11, 2023 •
edited
Loading

See
image

and

image

cc @Pytal

Also cc @blizzz
@szaimen szaimen added bug 1. to develop Accepted and waiting to be taken care of high regression labels Feb 11, 2023
@szaimen szaimen added this to the Nextcloud 25.0.4 milestone Feb 11, 2023
@szaimen szaimen changed the title NCSelect are broken in dark mode with 25.0.4 rc1 NcSelect are broken in dark mode with 25.0.4 rc1 Feb 11, 2023
@szaimen szaimen mentioned this issue Feb 13, 2023
Merged
@Pytal
Copy link
Member

Pytal commented Feb 13, 2023

Fixed in nextcloud-libraries/nextcloud-vue#3707

@szaimen
Copy link
Contributor Author

szaimen commented Feb 13, 2023

Thanks Chris! So this requires a new nextcloud/vue release and update in master and stable25 then? Shall I take care of this or is something missing for a new release?

@Pytal
Copy link
Member

Pytal commented Feb 14, 2023

Sure you can go ahead as there is nothing blocking release to my knowledge @szaimen :)

@szaimen
Copy link
Contributor Author

szaimen commented Mar 7, 2023

Should be fixed with 25.0.5

@szaimen szaimen closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of 25-feedback bug high regression
Projects
None yet
Milestone
Nextcloud 25.0.5
Development

No branches or pull requests
3 participants
@blizzz @Pytal @szaimen