Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.1.1.1a/3.7 - "Details" section / The combo box for selecting "Tags" - The button for deleting a tag does not have an alternative text. (2) #36718

Closed
3 tasks done
Pytal opened this issue Feb 15, 2023 · 3 comments
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement feature: tags
Milestone

Comments

@Pytal Pytal added enhancement 1. to develop Accepted and waiting to be taken care of accessibility labels Feb 15, 2023
@Pytal Pytal added this to the Nextcloud 26 milestone Feb 15, 2023
@Pytal Pytal self-assigned this Feb 15, 2023
@AndyScherzinger AndyScherzinger changed the title [BITV] "Details" section / The combo box for selecting "Tags" - The button for deleting a tag does not have an alternative text. [BITV] 9.1.1.1a/3.7 - "Details" section / The combo box for selecting "Tags" - The button for deleting a tag does not have an alternative text. Feb 16, 2023
@Pytal Pytal changed the title [BITV] 9.1.1.1a/3.7 - "Details" section / The combo box for selecting "Tags" - The button for deleting a tag does not have an alternative text. [BITV] 9.1.1.1a/3.7 - "Details" section / The combo box for selecting "Tags" - The button for deleting a tag does not have an alternative text. (2) Feb 22, 2023
@Pytal Pytal added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 26.0.1 Mar 20, 2023
@Pytal
Copy link
Member Author

Pytal commented Apr 1, 2023

Functionality additions to NcSelectTags being done in nextcloud-libraries/nextcloud-vue#3946

@Pytal
Copy link
Member Author

Pytal commented Apr 7, 2023

Options considered thus far are using NcSelectTags in https://github.com/nextcloud/server and passing prop overrides for systemtags functionality OR adding systemtags functionality to NcSelectTags itself as it already contains some systemtags specific code

Both of these options are infeasible in one way or another due to the discrepancy between internal and external state incurred by adding select, create, and delete functionality

For this reason as well as to maintain compatibility and to have an intuitive implementation we will need to make changes in https://github.com/nextcloud/nextcloud-vue and https://github.com/nextcloud/server

An opt-in prop will need to be added to override the custom internal state handling of NcSelectTags and all new systemtags specific logic will need to be done in the systemtags app

@Pytal
Copy link
Member Author

Pytal commented Apr 12, 2023

@nextcloud/vue changes done in nextcloud-libraries/nextcloud-vue#3968

Server changes done in #37065

@Pytal Pytal added 3. to review Waiting for reviews feature: tags and removed 2. developing Work in progress labels Apr 12, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 19, 2023
@Pytal Pytal closed this as completed Apr 24, 2023
@Pytal Pytal modified the milestones: Nextcloud 26.0.2, Nextcloud 27 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement feature: tags
Projects
None yet
Development

No branches or pull requests

3 participants