Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Share confirmations messages wrong #38157

Closed
5 tasks done
solracsf opened this issue May 9, 2023 · 2 comments · Fixed by #48696
Closed
5 tasks done

[Bug]: Share confirmations messages wrong #38157

solracsf opened this issue May 9, 2023 · 2 comments · Fixed by #48696
Assignees
@susnux
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug feature: language l10n and translations feature: sharing needs review Needs review to determine if still applicable regression

Comments

@solracsf
Copy link
Member

solracsf commented May 9, 2023 •
edited
Loading

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

server/apps/files_sharing/src/mixins/SharesMixin.js

Line 280 in fc07627

showSuccess(t('files_sharing', 'Share {propertyName} saved', { propertyName: propertyNames[0] }))

See screenshot

image

Steps to reproduce

  1. Create a share link
  2. Update expiration date or Hide dowload
  3. See confirmation messages

Expected behavior

Variables are implemented (and translated)

Nextcloud Server version

25
@solracsf solracsf added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels May 9, 2023
@solracsf
Copy link
Member Author

solracsf commented May 9, 2023

Cc @JuliaKirschenheuter as you're the author of #35655 😉

@solracsf solracsf mentioned this issue May 17, 2023
Closed
9 tasks
@solracsf solracsf mentioned this issue May 17, 2023
Merged
8 tasks
@AndyScherzinger
Copy link
Member

Also cc @Pytal due to the bank holiday in Germany

@solracsf solracsf added this to the Nextcloud 27 milestone May 18, 2023
@skjnldsv skjnldsv removed this from the Nextcloud 27.0.2 milestone Aug 8, 2023
@joshtrichards joshtrichards changed the title [Bug]: Share confirmations messages variables not implemented [Bug]: Share confirmations messages wrong Sep 17, 2024
@susnux susnux self-assigned this Oct 9, 2024
@susnux susnux moved this to 🏗️ In progress in 📁 Files team Oct 14, 2024
@susnux susnux mentioned this issue Oct 14, 2024
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susnux susnux

Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug feature: language l10n and translations feature: sharing needs review Needs review to determine if still applicable regression
Projects
📁 Files team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(files_sharing): Add proper user facing messages on success nextcloud/server
6 participants
@AndyScherzinger @joshtrichards @susnux @blizzz @solracsf @skjnldsv