Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Regression in apps using data-apps-slide-toggle for settings toggle button #38981

Closed
5 of 8 tasks
AsamK opened this issue Jun 24, 2023 · 2 comments · Fixed by #38988
Closed
5 of 8 tasks

[Bug]: Regression in apps using data-apps-slide-toggle for settings toggle button #38981

AsamK opened this issue Jun 24, 2023 · 2 comments · Fixed by #38988
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback bug regression

Comments

@AsamK
Copy link

AsamK commented Jun 24, 2023

⚠️ This issue respects the following points: ⚠️

Bug description

The settings can't be opened anymore some apps with NextCloud 27 (and newer). In apps that use the data-apps-slide-toggle attribute for implementing the settings toggle button the settings button doesn't work anymore.
Affects at least the News (nextcloud/news#2242) and Activity (nextcloud/activity#1199) apps.

The issue has been introduced in #36534, which removed the code handling the data-apps-slide-toggle attribute. This attribute is still documented for NextCloud 27 (https://docs.nextcloud.com/server/27/developer_manual/html_css_design/navigation.html#settings) so it was probably removed unintentionally and should be added back.

This is the code that needs to be added back:

Steps to reproduce

  1. Install news (beta) or activity app on NextCloud 27
  2. Click the settings button in the left bottom corner
  3. -> nothing happens

Expected behavior

When clicking the settings button, the settings should open.

Installation method

Community Manual installation with Archive

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 22 to 23)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@AsamK AsamK added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jun 24, 2023
@szaimen
Copy link
Contributor

szaimen commented Jun 24, 2023

Cc @skjnldsv

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 25, 2023
@skjnldsv
Copy link
Member

Hum, my bad, I don't remember searching for usage of that old feature, but I should have documented it! ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback bug regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants