-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/UX] Theming / Appearance and Accessibility management #39278
Comments
@joshtrichards thanks for looking into this! Feedback from my side:
Sounds good, but I would probably still use the individual settings with "mode". So that it says "Dark mode" instead of just "Dark" as that’s nicer when scanning through. The section heading can be "Color and contrast".
I’d say these sections are actually fine. We could add some clarifying info that it will overwrite the admin theming just for you, but I don’t think there is any confusion.
@juliushaertl @skjnldsv regarding this?
I disagree on this, as this should be completely up to the individual person, with "Follow system" being the default. If someone prefers to use dark mode everywhere, they should not need to look at Nextcloud in light mode, even if it’s just for the short time to change the setting.
Maybe "Follow device setting" instead of "System default theme"? This is more specific and clarifies "device" rather than "system". Technically the last deciding instance is your browser, but I would rather call it "Device" for simplicity.
Sure!
Yes, sounds good to group those. They should also be below the modes and above the background picker so it’s very quick to see them.
Since I disagree with the proposal of @joshtrichards would you like to contribute these things via pull request? :) |
@xBelladonna sounds very good! Since you already analyzed the issue and probably have a better font size in mind which works well, would you like to open a pull request to fix it? I know @nickvergessen sometimes (or often?) uses the dyslexia font as well, so he might have input too. |
I miss it since I use the Talk desktop client mostly nowadays and we don't have it there yet. I wondered if we should "narrow the spacing" in same areas manually with CSS when Dyslexia is used. |
@nickvergessen regarding the spacing I can imagine this is intentional to make it easier to read? So except adjusting the font size to fit that of our general font, I wouldn’t necessarily do anything to change it. |
|
Also known as: Global Theming, Appearance and accessibility, and User Theming
The Theming versus the User Appearance/Accessibility + User Theming stuff is a bit confusing. I mean in terms of:
In the UI we have...
...the Administration->"Theming": (
/settings/admin/theming
) page:I'd say the Admin page is actually pretty solid, with only minor potential tweaks (more on that in my proposal list).
Then we have also in the UI...
...the Personal->"Appearance and accessibility" (
/settings/user/theming
) page:I have some ideas to make the Personal page clearer (more on that in my proposal list).
Then in the system
config.php
we have:theme
<-- I believe this is legacy (i.e. only applicable if not using the theming app)enforce_theme
<-- Essentially legacy as it's no longer necessary with theming app having its own equivalent parameterI propose we:
/settings/user/theming
)"* page to clarify that's where the user adjustable (if permitted) theme overrides are/settings/user/theming
)" page since "theme" is a misnomer thereenforce_theme
parameter if it is indeed essentially depreciated or, at the very least, equivalent to the theming app's toggle for "Disable user theming"The above are some mid-morning thoughts that came together while looking into #39199 and attempting to clarify some of my longstanding confusion over theming/appearance/accessibility management/configuration. I reserve the right to revise this brain dump, but at least now it's recorded (for another time when I - or anyone else - has a better opportunity to dig deeper into actual implementation bits) . :-)
The text was updated successfully, but these errors were encountered: