Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wrong filenames in trash bin #39539

Closed
5 of 8 tasks
csware opened this issue Jul 22, 2023 · 8 comments
Closed
5 of 8 tasks

[Bug]: Wrong filenames in trash bin #39539

csware opened this issue Jul 22, 2023 · 8 comments
Labels
4. to release Ready to be released and/or waiting for tests to finish 27-feedback bug regression

Comments

@csware
Copy link
Contributor

csware commented Jul 22, 2023

⚠️ This issue respects the following points: ⚠️

Bug description

The trashbin view shows filenames as its.d1686841219 (some abbreviated before the .) or .d1686841232. When I click to restore the correct filename is used same applies when I click download. This issue occurred after an upgrade from 26.0.4 to 27.0.1. This affects files deleted with the old version before the update and also files deleted after the update.

Steps to reproduce

  1. Delete a file
  2. Go to the trashbin view

Expected behavior

The correct filename of the deleted file is shown as for Nextcloud < 27

Installation method

Community Manual installation with Archive

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version: 26.0.4 to 27.0.1

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "27.0.1.2",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "forcessl": true,
        "loglevel": 2,
        "integrity.check.disabled": false,
        "apps_paths": [
            {
                "path": "\/var\/www\/cloud.XXXX.de\/apps",
                "url": "\/apps",
                "writable": true
            }
        ],
        "maintenance": false,
        "theme": "",
        "overwrite.cli.url": "https:\/\/cloud.XXXX.de",
        "overwriteprotocol": "https",
        "activity_expire_days": 31,
        "trusted_domains": [
            "cloud.XXXX.de"
        ],
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trashbin_retention_obligation": "auto",
        "htaccess.RewriteBase": "\/",
        "mail_smtpmode": "sendmail",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "appstore.experimental.enabled": false,
        "singleuser": false,
        "log_rotate_size": 104857600,
        "logtimezone": "Europe\/Berlin",
        "mail_sendmailmode": "pipe",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "filelocking.enabled": true,
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "timeout": 0
        },
        "mysql.utf8mb4": true,
        "defaultapp": "files",
        "updater.release.channel": "stable",
        "default_phone_region": "DE",
        "mail_smtpauthtype": "PLAIN",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "preview_imaginary_url": "http:\/\/localhost:9000",
        "enabledPreviewProviders": [
            "OC\\Preview\\Imaginary"
        ],
        "updater.secret": "***REMOVED SENSITIVE VALUE***"
    }
}

List of activated Apps

Enabled:
  - activity: 2.19.0
  - bruteforcesettings: 2.7.0
  - calendar: 4.4.3
  - circles: 27.0.1
  - cloud_federation_api: 1.10.0
  - comments: 1.17.0
  - contacts: 5.3.2
  - contactsinteraction: 1.8.0
  - dashboard: 7.7.0
  - dav: 1.27.0
  - deck: 1.10.0
  - federatedfilesharing: 1.17.0
  - federation: 1.17.0
  - files: 1.22.0
  - files_external: 1.19.0
  - files_pdfviewer: 2.8.0
  - files_rightclick: 1.6.0
  - files_sharing: 1.19.0
  - files_trashbin: 1.17.0
  - files_versions: 1.20.0
  - firstrunwizard: 2.16.0
  - gpxpod: 5.0.12
  - impersonate: 1.14.0
  - logreader: 2.12.0
  - lookup_server_connector: 1.15.0
  - nextcloud_announcements: 1.16.0
  - notifications: 2.15.0
  - oauth2: 1.15.1
  - onlyoffice: 8.1.0
  - photos: 2.3.0
  - polls: 5.2.0
  - provisioning_api: 1.17.0
  - related_resources: 1.2.0
  - richdocuments: 8.1.0
  - serverinfo: 1.17.0
  - settings: 1.9.0
  - sharebymail: 1.17.0
  - spreed: 17.0.2
  - systemtags: 1.17.0
  - tasks: 0.15.0
  - text: 3.8.0
  - theming: 2.2.0
  - twofactor_backupcodes: 1.16.0
  - updatenotification: 1.17.0
  - user_status: 1.7.0
  - viewer: 2.1.0
  - weather_status: 1.7.0
  - workflowengine: 2.9.0
Disabled:
  - admin_audit: 1.17.0
  - encryption: 2.15.0
  - password_policy: 1.17.0 (installed 2.0.0)
  - privacy: 1.11.0 (installed 1.0.0)
  - recommendations: 1.6.0 (installed 0.4.0)
  - support: 1.10.0 (installed 1.0.0)
  - survey_client: 1.15.0 (installed 1.4.0)
  - suspicious_login: 5.0.0
  - twofactor_totp: 9.0.0
  - user_ldap: 1.17.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

In Firefox I see a lot of HTTP error 400 errors for https://cloud.XXXX.de/apps/files_trashbin/preview?fileId=4139741&x=32&y=32&a=0.

@csware csware added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 22, 2023
@joshtrichards
Copy link
Member

Confirmed.

Reproduced in:

  • v27.0.1

image

  • master:

image

Unable to reproduce in:

  • v27.0.0

image

@szaimen
Copy link
Contributor

szaimen commented Jul 22, 2023

Cc @skjnldsv

@bcutter
Copy link

bcutter commented Jul 24, 2023

I can confirm this too.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 25, 2023
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jul 25, 2023
@skjnldsv
Copy link
Member

fix in #39566

@gaticssa
Copy link

gaticssa commented Aug 1, 2023

I'm noticing other problems with the trash bin as well (version 27.0.1). I'm not sure if they're related, or something completely different:

  1. Some file deletion dates are wildly wrong
    A couple of hours ago, I deleted a few dozen docx files via the desktop client (all in one go, not one by one).
    The deletion dates for those files listed in the trash bin range from "10 days ago" to "4 minutes ago".

  2. Sorting by deletion date doesn't work
    No matter if the Deleted column is set to ascending or descending order, the files are not sorted by deletion date.
    The list gets rearranged when clicking the column header, but I can't figure out what criterion it's being sorted by.

Has anyone else seen these issues?

@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2023

@gaticssa it looks good from me.
What browser and version are you using?

@skjnldsv skjnldsv closed this as completed Aug 1, 2023
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 1, 2023
@gaticssa
Copy link

gaticssa commented Aug 1, 2023

What browser and version are you using?

I've tried with Firefox ESR 102.13.0esr and Vivaldi 6.1.3035.100 (both on Windows 10 22H2).

@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2023

Can you open a dedicated issue?
When doing so, please also post the response of the dav request.
It should start with <?xml version="1.0"?><d:multistatus xmlns:d="DAV:". Feel free to obfuscate the data with your text editor search and replace feature.

You also don't need to list the entire set of data, just a few files should be enough to check if the returned date fits what is displayed on your web interface.

image

How to access your browser network tab (Click to expand)

Chrome

  • Press either CTRL + SHIFT + J to open the “console” tab of the Developer Tools.
  • Alternative method:
    1. Press either CTRL + SHIFT + I or F12 to open the Developer Tools.
    2. Click the “network” tab.

Safari

  • Press CMD + ALT + I to open the Web Inspector.
  • See Chrome’s step 2. (Chrome and Safari have pretty much identical dev tools.)

Firefox

  • Press CTRL + SHIFT + K to open the Web console (COMMAND + SHIFT + K on Macs).
  • or, if Firebug is installed (recommended):
    1. Press F12 to open Firebug.
    2. Click on the “network” tab.

Opera

  1. Press CTRL + SHIFT + I to open Dragonfly.
  2. Click on the “network” tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish 27-feedback bug regression
Projects
Status: Done
Development

No branches or pull requests

7 participants