Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share node change between sidebar and Files app #40263

Closed
szaimen opened this issue Sep 4, 2023 · 0 comments · Fixed by #46030
Closed

Share node change between sidebar and Files app #40263

szaimen opened this issue Sep 4, 2023 · 0 comments · Fixed by #46030

Comments

@szaimen
Copy link
Contributor

szaimen commented Sep 4, 2023

I tested this and the icon does not seem to directly update after I shared the folder for example. I guess this should be the case though? Apart from that seems to work well so good work!

Needs a separate fix. We'll need to do a pass on global events. But right now the Sidebar doesn't update the files store, you are correct :)

Originally posted by @skjnldsv in #40192 (comment)

@szaimen szaimen added bug 1. to develop Accepted and waiting to be taken care of 28-feedback labels Sep 4, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Sep 4, 2023
@skjnldsv skjnldsv changed the title update the sharing icon in header when sharing the folder directly Share node change between sidebar and Files app Sep 5, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@nfebe nfebe self-assigned this Jun 25, 2024
@nfebe nfebe removed the 1. to develop Accepted and waiting to be taken care of label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants