-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android browsers: App Mode - Full Screen / No Address Bar #4047
Comments
@jancborchardt That's what I meant with "the current CSS is awkward", because we don't scroll the whole page but we scroll inside a fixed container, which breaks basically this browser feature 😉 |
cc @nextcloud/designers |
I think this is different, because the Radio FM4 page is not scrolled either, right? @Huster-at-github do you want to contribute a pull request to fix it? :) |
Why not just center the container with login, and have background cover for main div? It should work just fine. |
No, I think @MorrisJobke is right. Works fine with scrolling as well. And this is related to the complete site, not just the login. @Huster-at-github FM4 😍 |
Well the issue here is that we have a fixed header. Anyone have a good idea around this? |
There is also this quite nice library for hiding the header – we could hide the Nextcloud header itself with this: http://wicky.nillia.ms/headroom.js/ |
No. The reason is, that we have 100% height fixed and in there a scroll area (the app-content).
no way - why add a JS library where we also can cleanup our mess first and then look into further fixes. |
BTW, Im using that on the Website. |
I think you guys misunterstood @Huster-at-github 's problem. It is not about the url-bar hiding when scrolling down. On Chrome and Firefox for Android you can add a webpage to the homescreen so it can be launched like an app. There is also a feature where you can hide the url-bar so the webpage actually feels like a native app. To use this feature you just have to some simple steps as described here. I'd be happy to fix this issue. |
@Vetm sorry for the late reply – it would be awesome if you can fix this issue. :) You are very welcome to open a pull request! |
As a hint for anyone who wants to dig into this starter issue: We already have a manifest.json file. It seems like it is just loaded for logged in users and not on the login page. |
Fix is in #9982 |
Firefox and Chrome have the possibility to run web sites in "App Mode".
Example: Chrome withFM4 Radio Station:
![image](https://cloud.githubusercontent.com/assets/3857906/24318954/657d920e-110f-11e7-8826-d4813932666c.png)
Currently it looks like this in
Firefox:
![image](https://cloud.githubusercontent.com/assets/3857906/24318959/7f97bf16-110f-11e7-8a81-1e17d8a9c50b.png)
Chrome:
![image](https://cloud.githubusercontent.com/assets/3857906/24318962/97db7fea-110f-11e7-871c-ebd870dd224d.png)
The text was updated successfully, but these errors were encountered: