Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning about disk space needed for uploads to S3 #40539

Open
brainchild0 opened this issue Sep 20, 2023 · 3 comments
Open

Remove warning about disk space needed for uploads to S3 #40539

brainchild0 opened this issue Sep 20, 2023 · 3 comments
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback enhancement feature: dav feature: object storage

Comments

@brainchild0
Copy link

I am running Nextcloud 27.1.0, using an S3 bucket for primary storage.

As follows is one of the messages given under Security & setup warnings:

This instance uses an S3 based object store as primary storage. The uploaded files are stored temporarily on the server and thus it is recommended to have 50 GB of free space available in the temp directory of PHP. Check the logs for full details about the path and the available space. To improve this please change the temporary directory in the php.ini or make more space available in that path.

I have monitored the size and contents of directories for temporary files, as well as the application data directory, and the overall system disk usage, during uploads of large files. I have found no evidence of uploaded files being stored as temporary files.

Similarly, #27034 suggests that the message is obsolete (even though #19414 remains open).

If the message is obsolete, please remove it.

Otherwise, please clarify the current behavior.
@brainchild0 brainchild0 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Sep 20, 2023
@joshtrichards
Copy link
Member

It depends on client support. The messaging can probably be adjusted "soon" so that it clarifies that it impacts some clients (i.e. older client versions and others like third-party WebDAV clients) that don't implement v2 chunking API.

It wasn't until a few weeks ago it was fully implemented across Desktop (nextcloud/desktop#5554, Android (nextcloud/android-library#1173), iOS (nextcloud/ios#2541), and Files/Web (nextcloud-libraries/nextcloud-upload#925).

@joshtrichards joshtrichards added feature: object storage 1. to develop Accepted and waiting to be taken care of 27-feedback and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 21, 2023
@joshtrichards
Copy link
Member

Further clarification:

It also currently still impacts public/anonymous uploads AFAIK.

@brainchild0
Copy link
Author

Will third-party WebDAV clients always require temporary files?

Is it possible to create logic that chunks a file for multiple write operations to S3 within the same WebDAV request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback enhancement feature: dav feature: object storage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshtrichards @brainchild0