Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV]: breadcrumbs home link without href #42624

Closed
JuliaKirschenheuter opened this issue Jan 8, 2024 · 2 comments
Closed

[BITV]: breadcrumbs home link without href #42624

JuliaKirschenheuter opened this issue Jan 8, 2024 · 2 comments
Assignees
@emoral435
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement

Comments

@JuliaKirschenheuter
Copy link
Contributor

Screenshot from 2024-01-08 14-08-34

<a data-v-3ddab287="" title="Home" aria-label="Home"> have to have a valid href attr
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Jan 8, 2024
@ShGKme ShGKme assigned ShGKme and unassigned ShGKme Jan 8, 2024
@emoral435 emoral435 self-assigned this Jan 10, 2024
This was referenced Jan 12, 2024
Closed
Merged
@emoral435 emoral435 added pending dependency update enhancement 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Jan 16, 2024
@JuliaKirschenheuter
Copy link
Contributor Author

@emoral435 could you please check if your PR is already in NcVue release? If not then it is not Done, but Parked

@emoral435
Copy link
Contributor

emoral435 commented Feb 2, 2024 •
edited
Loading

Ah - I got mixed up on which PR this should go in! My bad, should be ready to be a11y28checked once #43064 gets merged! (in fact, once we have it bumped to 8.5.0 it should be good, but just the styling is off for the component 🙈)

@szaimen szaimen closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emoral435 emoral435

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JuliaKirschenheuter @ShGKme @szaimen @emoral435