Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing folder which contains a shared file/folder fails #4328

Closed
faulix opened this issue Apr 12, 2017 · 9 comments
Closed

Sharing folder which contains a shared file/folder fails #4328

faulix opened this issue Apr 12, 2017 · 9 comments

Comments

@faulix
Copy link

faulix commented Apr 12, 2017

Steps to reproduce

  1. Someone shares a file/folder with you
  2. Save/move the file/folder to one of your folders
  3. Try so share your folder with anyone

Expected behaviour

As long as I have the full permissions for all containing files including the ones shared with me, I expect that sharing my folder is possible even though it contains an other shared folder.

Actual behaviour

Error "Path contains files shared with you"

@MorrisJobke
Copy link
Member

I guess this is expected behaviour, right @rullzer and @schiessle

@rullzer
Copy link
Member

rullzer commented Apr 12, 2017

Yes. This is by design.

The owner of the files should always know who has access. If you share a topfolder of a share then this information is not there. We chose for a flat sharing model instead of a hierarchical model.

@rullzer rullzer closed this as completed Apr 12, 2017
@faulix
Copy link
Author

faulix commented Apr 12, 2017

But I can directly share the file/folder with additional people, so where's the difference? In the end I can still share the file/folder with whoever I want, so why not conveniently by sharing the parent folder?

@rullzer
Copy link
Member

rullzer commented Apr 12, 2017

Yes you can share the folder with who you want (if sharing permissions are given to you). But if you share the same folder the owner will know it. If you share the parent folder this becomes non trivial. We need to do a lot of booking them and this is just not doable from a performance/scalability point of view.

@faulix
Copy link
Author

faulix commented Apr 12, 2017

But then a valid tradeoff would be to check if the shared folder already have the required permissions and in this case to allow the sharing, wouldn't it be?

@MorrisJobke
Copy link
Member

But then a valid tradeoff would be to check if the shared folder already have the required permissions and in this case to allow the sharing, wouldn't it be?

Yes, that would be the solution, but the tradeoff here is performance and we just want to go for performance than for this solution.

@ppreiss
Copy link

ppreiss commented Apr 16, 2024

Thank you for the explanation.

I run into this issue with a shared folder containing many subfolders. How do I figure out which subfolder is preventing me from sharing the parent folder? There are too many to check individually.

@martok
Copy link

martok commented Aug 1, 2024

I run into this issue with a shared folder containing many subfolders. How do I figure out which subfolder is preventing me from sharing the parent folder? There are too many to check individually.

In principle one could go through the "Shared with me" list and figure out which list item links to a subfolder of the folder in question. But that list doesn't include any remote shares, which also block creating a share.
In my case I had a fairly good idea what it could be and went by the icon overlay provided by the sync client on windows, but that's really not convenient.

Ideally the error message would just tell the user what's wrong. The other way around, moving an incoming share into an already shared folder, is even worse. "Move or copy" action failed, no further information.

@ErikUden
Copy link

I would like for this issue to be reopened, especially due to the fact of federation. If someone of a different instance shares something with you, you can re-share it with a link by the local instance. The original creator of the share will have no idea this happened. Hence resharing directories with shared content (from a different instance) inside should be possible.

What am I trying to do?

Imagine I have pictures of someone, partially stored on a different Nextcloud instance, partially stored on mine. Lets say the other instance is for specific purposes (political, clubs, etc.) and my instance is for personal stuff. However, I'd like to have one place where all the images come together! I've compiled that place with all the images from both sources.

Now let's say that person asks “hey, can you send me all the images you have of me?”

Okay, now that I'm writing this I am realizing that all I need to do is share two links. Still, I think this should be possible, I still love Nextcloud in case you decide not to add this, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants