Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sharing UI #434

Closed
rullzer opened this issue Jul 18, 2016 · 10 comments
Closed

New sharing UI #434

rullzer opened this issue Jul 18, 2016 · 10 comments
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: sharing

Comments

@rullzer
Copy link
Member

rullzer commented Jul 18, 2016

The flat sharing model has brought advantages in better control over your data. But it poses a UX problem.

To recap what this means. Flat sharing means that each share has 3 participants.

  • Share owner (owner of the data)
  • Share initiator (sharer of the data)
  • Share recipient (sharee of the data)

This means the following.

  • UserA shares with userB
  • UserB shares with userC

Now userA should see that the data is shared with userB (by themself) and with userC (by userB). Maybe hover
is good enough here?

LINK shares

Situation 1

Now because the shares are flat we also have multiple link shares.

  • UserA shares with userB
  • UserA shares by link
  • userB shares by link

Now userA should see 2 link shares

Situation 2

We should use different link shares for this so permissions can be revoked separatly

Situation 3

Very similar to situation 2:

  • UserA shares a folder RO to some friends by e-mail
  • UserA shares the same folder with fildes drop to some forum for input
  • UserA also shares the same folder with files drop to some other forum

All of those should be different links. As to keep control and not to have to
send some people a new link if you want to revoke 1.

Security considerations

I would like to have permission control before I share.
Right now we share (RW by default). And only after it we limit the permissions. This should be the other way around

  • user types in username
  • simple box next to it with permissions (RW+S, RW, R?)

This means that before we share we can chose the permissions.
I'm fine with keeping the default as is. But I want to be able to do this before sharing

** See how google does this **

Federated sharing

Something i have been thinking about is abstracting away from local/remote shares.
So instead of userB and userC@remoteinstance.com the users would all be shown as

Or something fancier. And of course we can do awesome autocomplete and all.
Because right now the separation feels weird and users don't care. They just want to share

@nextcloud/designers could you mock something up?

@rullzer rullzer added enhancement design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of labels Jul 18, 2016
@NomoreGlitches
Copy link

NomoreGlitches commented Aug 28, 2016

Just as an additional issue, I'd like my customers not be able to Unshare important files I share with them, as otherwise they are definitely coming back to me asking for those files again and again. In a scenario where one has 1274 customers, this could get crazy!
What about an extra permissions button prohibiting unsharing?

@rullzer
Copy link
Member Author

rullzer commented Aug 28, 2016

Well we are working on an overiew page where you can retrieve deleted shares (as long as the share owner has still shared it with you). But a possibility to make it impossible to delete shares is not something I would want.

Because then I already see everybody sharing everything with that permission on all the time. We want the user to be in control of their data.

@NomoreGlitches
Copy link

NomoreGlitches commented Aug 29, 2016

Thanks for replying! The concern is definitely understandable to me, although maybe I could imagine some pure corporate applications where "non-unsharable" files might not be very restrictive for the user, since it is the responsibility of the company to maintain the shared files consistent.
But ok, the ability of retrieving unshared files covers pretty much the same need.

@mvisser00
Copy link

@rullzer, can you update me on the status of this feature? Is it still being worked on atm?

@jospoortvliet
Copy link
Member

So the overview of 'undelete shares' is there in NC 14; for shares that shouldn't be deleted there exists the Group Folders app.

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Aug 17, 2018
@rullzer
Copy link
Member Author

rullzer commented Aug 17, 2018

Works only for group shares now

@jancborchardt
Copy link
Member

Created a mockup & spec for the security considerations part at Ability to set permissions before sharing #13229

@jancborchardt
Copy link
Member

@rullzer there has been a bunch of work on this, and more is ongoing. That and also the Ability to set permissions before sharing #13229 I think make this issue obsolete. Do we close it? :)

@szaimen

This comment has been minimized.

@jospoortvliet
Copy link
Member

together with Jan's ability to set permissions before sharing issue and the changes we did for 18, I agree with him that this can be closed... let me just do that in the interest of cleaning up, feel free to re-open, roeland! And smack me digitally on the head for closing, if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: sharing
Projects
None yet
Development

No branches or pull requests

8 participants