Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Regression on external files (SMB) if caseSensitive is false #43633

Closed
4 of 8 tasks
danielnachtrub opened this issue Feb 17, 2024 · 3 comments
Closed
4 of 8 tasks
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug feature: external storage hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. needs info stale Ticket or PR with no recent activity

Comments

@danielnachtrub
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

If external files are mounted via SMB, one of the recent commits introduced a bug that files cannot be accessed and directories cannot be listed anymore.

The affected change is shown here:
a45e12a#diff-65a0745a50632503b67e22fc4fe11789b6cbd41e3fedd475076fcee2144da0d5R686

Omitting this section returns expected functionality.

Steps to reproduce

  1. Add external storage via SMB
  2. Disable case sensitive
  3. Try to access external storage

Expected behavior

Files and Directories should be listed

Installation method

Community Docker image

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@danielnachtrub danielnachtrub added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Feb 17, 2024
@Censored3
Copy link

Don't know if any extra info is needed on this, but I encountered this issue and discovered during traces that the folder queried on the SMB server is actually 2x the subfolder specified in the config.

E.g., if I configure server 1.2.3.4, share MyShare$, subfolder: Projects/Subproject,
I see queries happening for folder: "Projects\Subproject\Projects\Subproject"

@joshtrichards
Copy link
Member

joshtrichards commented Aug 1, 2024

Without more details I can't say for certain, but this may have been addressed by #43349 (which was released in 28.0.3 a few weeks after your report).

@joshtrichards joshtrichards added the hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. label Aug 27, 2024
@nextcloud-command
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@nextcloud-command nextcloud-command added the stale Ticket or PR with no recent activity label Sep 27, 2024
@nextcloud-command nextcloud-command closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug feature: external storage hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. needs info stale Ticket or PR with no recent activity
Projects
None yet
Development

No branches or pull requests

5 participants