[Bug]: "Delete file" and "Delete folder" context menu items not localised on v27.1.7

[ostasevych]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Files context menu items Delete file and Delete folder appear to be not localised after the last update from 27.1.6 to 27.1.7.

Steps to reproduce

1. Click context menu and observe the issue.
   

Expected behavior

Should be localised.

Installation method

None

Nextcloud Server version

26

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

in uk.js I observe the change of the format from the last version:
in 27.1.6:

    "Delete file" : "Вилучити файл",
    "Delete folder" : "Вилучити каталог",

in 27.1.7:

    "_Delete file_::_Delete files_" : ["Вилучити файл","Вилучити файли","Вилучити файли","Вилучити файли"],
    "_Delete folder_::_Delete folders_" : ["Вилучити каталог","Вилучити каталоги","Вилучити каталоги","Вилучити каталоги"],

Is this something related to?

[susnux]

My guess here: We take translations from master / stable28 were that string is pluralized due to batch actions being possible.
But we should update changes like that to older stable branches.

Maybe @skjnldsv knows more about the CI that updates the translations?

[skjnldsv]

Is this actually translated on transifex?

[ostasevych]

Is this actually translated on transifex?

Sure :)
https://app.transifex.com/nextcloud/nextcloud/translate/#uk/files/483799062?q=text%3A'delete+file'

[susnux]

As said my guess it that we update translations from current master -> so the string is now pluralized and thus the frontend translate function can not translate it anymore.

[skjnldsv]

I don't remember how it works.
if that was the case, it would mean every non-master releases would have translations missing for years no?
I mean, we change a lot of apps and various strings...

[ostasevych]

"Delete file::Delete files" : ["Вилучити файл","Вилучити файли","Вилучити файли","Вилучити файли"],
"Delete folder::Delete folders" : ["Вилучити каталог","Вилучити каталоги","Вилучити каталоги","Вилучити каталоги"],

Is this formatting supported in 27.1.x?

[skjnldsv]

@blizzz @nickvergessen do you know more?

[nickvergessen]

Strings from all versions we translate are combined.

But the string looks a bit weird anyway as the number is not included?
Do you have a link to the respective source code?

[skjnldsv]

28 and 29

server/apps/files/src/actions/deleteAction.ts

Line 90 in 12fe865

return n('files', 'Disconnect storage', 'Disconnect storages', nodes.length)

server/apps/files/src/actions/deleteAction.ts

Line 97 in 12fe865

return n('files', 'Delete file', 'Delete files', nodes.length)

27

server/apps/files/js/fileactions.js

Lines 784 to 786 in 9a4f2f1

	var deleteTitle = (type && type === 'file')
	? t('files', 'Delete file')
	: t('files', 'Delete folder')

[susnux]

So yes this is a problem of combining the strings, if it was singular previously and then the same string is provided as plural option we can not use it anymore in the frontend. (Because the translation key is merged into a plural version and thus we can not detect it anymore).

Two fixes possible:

1. Also change 27 and 26 to the plural version (easy)
2. Adjust our translation logic to somehow figure out the plural key and try that one as well. (harder)

[nickvergessen]

That being said, the strings in

server/apps/files/src/actions/deleteAction.ts

Line 90 in 12fe865

return n('files', 'Disconnect storage', 'Disconnect storages', nodes.length)

are "undistinct" plurals.

So this could be changed to a "non-pluraled" string as they do not need to follow a dedicated plural rule as you basically want to say "Delete many folders" so something like this would work:

	if (isAllFolders(nodes)) {
		if (nodes.length === 1) {
			return t('files', 'Delete folder')
		}
		// We don't really want to count and show the number, so using generic plural instead of a pluraled-string
		return t('files',  'Delete folders')
	}

[nickvergessen]

That being said, I think it's a bug from the tooling that it can not handle translations of the same string that is a plural

[skjnldsv]

so something like this would work:

	if (isAllFolders(nodes)) {
		if (nodes.length === 1) {
			return t('files', 'Delete folder')
		}
		// We don't really want to count and show the number, so using generic plural instead of a pluraled-string
		return t('files',  'Delete folders')
	}

Far less clean though 🙃

[nickvergessen]

Far less clean though 🙃

But what you do (translating a plural without a number in it) is confusing for translators of languages that have 6 plural forms. How should they guess that they need to put in the "undistinct" in all of them.

[camilasan]

2. Adjust our translation logic to somehow figure out the plural key and try that one as well.

What is the plural key?

[nickvergessen]

the English one is _singular_::_plural_

server/apps/files/l10n/de.js

Line 75 in 8b4864f

"_%n folder_::_%n folders_" : ["%n Ordner","%n Ordner"],

but this is really not the way to go. Just don't use plurals for this, unless you have the %n in it.

[ostasevych]

Hi! How is that solved? In the recent 27.x upgrade I cannot find the updated localisation :(

[nickvergessen]

It was fixed right after the release and backporting is still to be done next week

[ElSi-DVT]

Problem still exists in 27.1.8

[nickvergessen]

yes, it will be solved with 27.1.9

or you replace your language files with the new ones from https://github.com/nextcloud/server/tree/stable27/apps/files/l10n