-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naughty words in generated URLs #4397
Comments
You had |
@nickvergessen Yep, public share link right there at the front. Noticed a few days after it was sent to a customer. |
That's a bit unfortunate, but I guess filtering everything out is hard. I just had The problem is, who decides whether a word is a naughty word, and which languages should we check? What happens with leed replacements? Because if they are still Currently I'd personally just say "sorry, please regenerate on your own". |
I agreed. Just thought it was worth pointing out. |
Btw the change calculation is wrong, it's actually: (26 + 26 + 10)^4 / 12 Because we have 15 chars, so there can be 12 beginnings for a 4 letter word. |
So, (15 + 15 + 10) ^ 4 = 2,560,000 With odds like that might need to reopen the issue :). |
When looking around for other incidents in a more or less similar fashion and it's handling with it: also the German national football team did not change the names of their players: |
Just had a 1 in 14 million event occur[1]: Nextcloud generated a URL with a path that starts with a four letter word beginning with c. Now, I'm very progressive, but others might feel it's a slight. Is it worth having a map of naughty words to non-naughty strings?
Steps to reproduce
[1] (26 + 26 + 10)^4 = 14,776,336
The text was updated successfully, but these errors were encountered: