Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Search in the"disabled users" section does not work #44936

Closed
5 of 8 tasks
bigcat88 opened this issue Apr 19, 2024 · 7 comments · Fixed by #45370
Closed
5 of 8 tasks

[Bug]: Search in the"disabled users" section does not work #44936

bigcat88 opened this issue Apr 19, 2024 · 7 comments · Fixed by #45370
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug

Comments

@bigcat88
Copy link
Member

⚠️ This issue respects the following points: ⚠️

Bug description

In the Nextcloud 28.0.4 version, the search in the "disabled users" section does not work.
If a search string is entered in the search mask, nothing can be found and the list of all deactivated users is still displayed.

Steps to reproduce

  1. go to nc.url/settings/users/disabled
  2. click on Unified Search
  3. type anything and see that the list of users is not filtered

Expected behavior

The same as for "Active Users", ability to use search like a filter

Installation method

None

Nextcloud Server version

28

Operating system

None

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

None

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

Filter do not do it's job:

image
@bigcat88 bigcat88 added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 19, 2024
@sorbaugh
Copy link
Contributor

Looping in @Altahrim and @fenn-cs as this seems related to Unified Search

@joshtrichards
Copy link
Member

Reminds me of #43658 a little.

@Pytal
Copy link
Member

Pytal commented May 7, 2024

Had a look and filtering in the disabled users section doesn't work like it does in "Active users" because we use an optimized endpoint for querying disabled users which unlike the general users endpoint does not accept a search query

We would need to accept a search query here

public function getDisabledUserList(?int $limit = null, int $offset = 0): array;
and update the LDAP implementation cc @come-nc

@come-nc
Copy link
Contributor

come-nc commented May 13, 2024

It’s a bit complicated to support search in disabled users. We’d need to add a search parameter to implementations of IProvideEnabledStateBackend, which means adding yet another interface as this one is out already.
Or we filter in user management but that will be slow and resource expensive.

@Pytal
Copy link
Member

Pytal commented May 13, 2024

It’s a bit complicated to support search in disabled users. We’d need to add a search parameter to implementations of IProvideEnabledStateBackend, which means adding yet another interface as this one is out already. Or we filter in user management but that will be slow and resource expensive.

I'd say the best option would be adding the search param as since user listing is paginated then filtering on frontend only would show no existing user if they have not already been fetched in the batch of paged users unlike in "Active users"

@Altahrim
Copy link
Collaborator

Version 27 was using this endpoint: /ocs/v2.php/cloud/users/details?offset=0&limit=25&search=<search>. Maybe it can help to reenable it?

@come-nc
Copy link
Contributor

come-nc commented May 14, 2024

Version 27 was using this endpoint: /ocs/v2.php/cloud/users/details?offset=0&limit=25&search=<search>. Maybe it can help to reenable it?

Reenable it where?
It is still used for enabled users I think. The problem is disabled users are now fetched through a dedicated endpoint and search was not baked in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants